diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2016-05-19 16:08:44 +0300 |
|---|---|---|
| committer | Jon Turney <jon.turney@dronecode.org.uk> | 2016-06-08 14:42:51 +0300 |
| commit | 110c18bd83aeca38f40b582a8db1c99cb51d77af (patch) | |
| tree | 6f28a8eeebc246e1b25c27840deaf014028de823 | |
| parent | d86f99a0ec043f09521e35658d9ab6364e107642 (diff) | |
Directly check package is in self-source list
Rather than adding a hint to indicate that a package is on the self-source
list and then later checking for that hint, directly check if it's on the
self-source list.
| -rwxr-xr-x | calm/package.py | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/calm/package.py b/calm/package.py index bf3d680..27a28fb 100755 --- a/calm/package.py +++ b/calm/package.py @@ -206,11 +206,6 @@ def read_package(packages, basedir, dirpath, files, strict=False): # now we have read the package, fix some common defects in the hints # - # note if the package is self-source - # XXX: this should really be defined as a setup.hint key - if p in past_mistakes.self_source: - packages[p].hints['self-source'] = '' - # don't allow a redundant 'package:' or 'package - ' at start of sdesc # # match case-insensitively, and use a base package name (trim off any @@ -443,7 +438,7 @@ def validate_packages(args, packages): continue # unless this package is marked as 'self-source' - if 'self-source' in packages[p].hints: + if p in past_mistakes.self_source: continue logging.error("package '%s' version '%s' is missing source" % (p, v)) |