diff options
| author | Christopher Faylor <me@cgf.cx> | 2013-07-20 03:13:58 +0400 |
|---|---|---|
| committer | Christopher Faylor <me@cgf.cx> | 2013-07-20 03:13:58 +0400 |
| commit | fb6cf945f91f2b39edbe838eacb4fad85d153376 (patch) | |
| tree | 90ab9d57c06ffccede462a8f7f177e8d619c2d7c | |
| parent | 3a4dab46c36a9a916cc87ce2ba6fc86202578ef9 (diff) | |
* exceptions.cc (signal_exit): Add a FIXME comment.
| -rw-r--r-- | winsup/cygwin/ChangeLog | 4 | ||||
| -rw-r--r-- | winsup/cygwin/exceptions.cc | 2 | ||||
| -rw-r--r-- | winsup/cygwin/release/1.7.22 | 4 |
3 files changed, 10 insertions, 0 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index c36862ce8..aa970d2f0 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,5 +1,9 @@ 2013-07-19 Christopher Faylor <me.cygwin2013@cgf.cx> + * exceptions.cc (signal_exit): Add a FIXME comment. + +2013-07-19 Christopher Faylor <me.cygwin2013@cgf.cx> + * exceptions.cc (signal_exit): Only dump core when it's a "kernel" signal. Only use RtlCaptureContext on x86_64. It doesn't seem to do what's expected on x86. diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc index 3f1cdbfdb..0b7053cb2 100644 --- a/winsup/cygwin/exceptions.cc +++ b/winsup/cygwin/exceptions.cc @@ -1219,6 +1219,8 @@ signal_exit (int sig, siginfo_t *si) sig |= 0x80; /* Flag that we've "dumped core" */ if (try_to_debug ()) break; + /* FIXME: We're still dumping core even if !(sig & 0x80). Need to + investigate if the else clause can just be nuked. */ if (si->si_code != SI_USER && si->si_cyg) ((cygwin_exception *) si->si_cyg)->dumpstack (); else diff --git a/winsup/cygwin/release/1.7.22 b/winsup/cygwin/release/1.7.22 index 16fbe18ff..d5b7e8355 100644 --- a/winsup/cygwin/release/1.7.22 +++ b/winsup/cygwin/release/1.7.22 @@ -31,3 +31,7 @@ Bug fixes: - Fix a timer handle leak in sleep family of functions. Fixes: http://cygwin.com/ml/cygwin/2013-07/msg00379.html + +- Fix issue with raise() not causing the process to exit with a signal + status. Also only set "dumped core" flag when it's a "kernel" signal. + See: http://cygwin.com/ml/cygwin-apps/2013-07/msg00251.html |