diff options
| author | Corinna Vinschen <corinna@vinschen.de> | 2001-12-30 01:03:32 +0300 |
|---|---|---|
| committer | Corinna Vinschen <corinna@vinschen.de> | 2001-12-30 01:03:32 +0300 |
| commit | e37f6c57cd870ecbb99287e79b28872d8725543b (patch) | |
| tree | af7397cea29c4db3a67131c8c496e63283c76d85 | |
| parent | 971ec8d3102e6f32d24e44c56e8656a45bec4c4e (diff) | |
* security.cc (open_local_policy): Initialize lsa handle to NULL.
Request only needed access rights in call to LsaOpenPolicy().
(create_token): Check for NULL lsa pointer.
| -rw-r--r-- | winsup/cygwin/ChangeLog | 6 | ||||
| -rw-r--r-- | winsup/cygwin/security.cc | 7 |
2 files changed, 10 insertions, 3 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 0370760ea..bdfd47175 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,9 @@ +2001-12-29 Corinna Vinschen <corinna@vinschen.de> + + * security.cc (open_local_policy): Initialize lsa handle to NULL. + Request only needed access rights in call to LsaOpenPolicy(). + (create_token): Check for NULL lsa pointer. + 2001-12-28 Corinna Vinschen <corinna@vinschen.de> * cygwin.din: Add symbols for endutent(), getutent(), getutid(), diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc index cf30386e8..3147c8abe 100644 --- a/winsup/cygwin/security.cc +++ b/winsup/cygwin/security.cc @@ -181,9 +181,10 @@ static LSA_HANDLE open_local_policy () { LSA_OBJECT_ATTRIBUTES oa = { 0, 0, 0, 0, 0, 0 }; - LSA_HANDLE lsa = INVALID_HANDLE_VALUE; + LSA_HANDLE lsa = NULL; - NTSTATUS ret = LsaOpenPolicy(NULL, &oa, POLICY_ALL_ACCESS, &lsa); + NTSTATUS ret = LsaOpenPolicy(NULL, &oa, POLICY_VIEW_LOCAL_INFORMATION + | POLICY_LOOKUP_NAMES, &lsa); if (ret != STATUS_SUCCESS) set_errno (LsaNtStatusToWinError (ret)); return lsa; @@ -739,7 +740,7 @@ create_token (cygsid &usersid, cygsid &pgrpsid) goto out; /* Open policy object. */ - if ((lsa = open_local_policy ()) == INVALID_HANDLE_VALUE) + if (!(lsa = open_local_policy ())) goto out; /* Get logon server. */ |