diff options
| author | Ken Brown <kbrown@cornell.edu> | 2021-04-02 21:47:36 +0300 |
|---|---|---|
| committer | Ken Brown <kbrown@cornell.edu> | 2021-04-07 17:16:26 +0300 |
| commit | a52dd4aab53965b28e7ec0ba460dbf24a1fd2b92 (patch) | |
| tree | b4f324d3eb9eeba6f6228ef30bb9af7f37dd3cf0 | |
| parent | 24ac223828eaca1acdce4a926ef0b5dd7124f24f (diff) | |
Cygwin: AF_UNIX: Add/remove FIXME comments
| -rw-r--r-- | winsup/cygwin/fhandler_socket_unix.cc | 2 | ||||
| -rw-r--r-- | winsup/cygwin/select.cc | 5 |
2 files changed, 2 insertions, 5 deletions
diff --git a/winsup/cygwin/fhandler_socket_unix.cc b/winsup/cygwin/fhandler_socket_unix.cc index dc71a8d2a..18e4f2971 100644 --- a/winsup/cygwin/fhandler_socket_unix.cc +++ b/winsup/cygwin/fhandler_socket_unix.cc @@ -2457,6 +2457,8 @@ fhandler_socket_unix::recvmsg (struct msghdr *msg, int flags) } /* FIXME: Should the shutdown check be done for connected datagram sockets too? */ + /* FIXME: This isn't quite right. There may be data in the + pipe that hasn't been read yet. */ grab_admin_pkt (); if (saw_shutdown () & _SHUT_RECV || tot == 0) { diff --git a/winsup/cygwin/select.cc b/winsup/cygwin/select.cc index 8966d45ec..b547404bb 100644 --- a/winsup/cygwin/select.cc +++ b/winsup/cygwin/select.cc @@ -1938,7 +1938,6 @@ fhandler_socket_wsock::select_except (select_stuff *ss) s->cleanup = socket_cleanup; } s->peek = peek_socket; - /* FIXME: Is this right? Should these be used as criteria for except? */ s->except_ready = saw_shutdown_write () || saw_shutdown_read (); s->except_selected = true; return s; @@ -2194,9 +2193,6 @@ fhandler_socket_unix::select_write (select_stuff *ss) || connect_state () == unconnected; if (connect_state () != unconnected) { - /* FIXME: I copied this from the wsock case, but it doesn't seem - right. Why are we setting except_ready here rather than in - select_except? */ s->except_ready = saw_shutdown (); s->except_on_write = true; } @@ -2215,7 +2211,6 @@ fhandler_socket_unix::select_except (select_stuff *ss) s->verify = verify_ok; s->cleanup = socket_unix_cleanup; s->except_selected = true; - /* FIXME: Is this right? */ s->except_ready = saw_shutdown (); grab_admin_pkt (); |