diff options
| author | Takashi Yano <takashi.yano@nifty.ne.jp> | 2022-05-08 13:45:31 +0300 |
|---|---|---|
| committer | Takashi Yano <takashi.yano@nifty.ne.jp> | 2022-05-08 13:45:31 +0300 |
| commit | b29fd96cac1df380d2be05892dab35888598186f (patch) | |
| tree | f8f5440bde76e0e15a0eb8bbb595f109d9851658 | |
| parent | aa9b5262f238d446260ec06d962f4c325a64dd89 (diff) | |
Cygwin: pty: Fix acquiring attach_mutex timing.
- When temporarily attaching a console, the timing of acquiring
attach_mutex was not appropriate. This sometimes caused master
forwarding thread to crash on Ctrl-C in Windows 7. This patch
fixes the issue.
| -rw-r--r-- | winsup/cygwin/fhandler_tty.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc index 484bf55dc..bdde1dce6 100644 --- a/winsup/cygwin/fhandler_tty.cc +++ b/winsup/cygwin/fhandler_tty.cc @@ -4171,13 +4171,13 @@ DWORD fhandler_pty_common::attach_console_temporarily (DWORD target_pid) { DWORD resume_pid = 0; + acquire_attach_mutex (mutex_timeout); pinfo pinfo_resume (myself->ppid); if (pinfo_resume) resume_pid = pinfo_resume->dwProcessId; if (!resume_pid) resume_pid = get_console_process_id (myself->dwProcessId, false); bool console_exists = fhandler_console::exists (); - acquire_attach_mutex (mutex_timeout); if (!console_exists || resume_pid) { FreeConsole (); |