diff options
author | Hans-Peter Nilsson <hp@bitrange.com> | 2018-09-13 18:48:48 +0300 |
---|---|---|
committer | Hans-Peter Nilsson <hp@bitrange.com> | 2018-09-13 18:58:01 +0300 |
commit | e3ddbeb84c36e3bf6aec7a70be9c2ed8ad6ef9bd (patch) | |
tree | 66da44855e572bd7fe0151eedd375f2650226140 /newlib | |
parent | a6837ca34f9aebe1bada63334eaedb5866beaa4f (diff) |
Committed, CRIS port: fix fallout from time_t defaulting to 64 bits, part 2
It's been a while... I see the CRIS port broke with the
time_t-default-to-64-bit change, observable by a few test-cases in the gcc
fortran(!) tests failing, regressing when trying a recent newlib.
This is a two-part belt-and-suspenders change: adjust the CRIS port
gettimeofday syscall (the only one in newlib/CRIS passing a time_t or
struct timeval) to handle a userspace 64-bit time_t and secondly default
time_t to 32-bit long anyway. I considered making the local
"kernel_timeval" copy in _gettimeofday conditional on (userspace) time_t
being 64 bits, but thought it not worth bothering with the few move insns.
The effect of a 64-bit time_t is however observable as longer simulation
time when running the gcc testsuite and as bigger binaries without any
actual upside from the larger time_t size, so I thought better make the
default for this port go back to being a "long" again.
Tested by running the gcc testsuite over the three combinations of two
parts of the patch and observing the expected changes. Committed.
newlib:
* configure.host (cris, crisv32): Default to "long" time_t.
Signed-off-by: Hans-Peter Nilsson <hp@axis.com>
Diffstat (limited to 'newlib')
-rw-r--r-- | newlib/configure.host | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/newlib/configure.host b/newlib/configure.host index 7e9336a0a..c5b773465 100644 --- a/newlib/configure.host +++ b/newlib/configure.host @@ -135,6 +135,12 @@ case "${host_cpu}" in machine_dir=cr16 ;; cris | crisv32) + # The size of the (kernel_)time_t passed from or to a + # simulator or a Linux kernel is mandated by the + # gettimeofday and time system calls and fixed to 32 bits, the + # size of a long. Instead of churning as 64 bits what is anyway + # 32 bits, it makes more sense to default to long. + test -z "${enable_newlib_long_time_t}" && newlib_long_time_t=yes machine_dir=cris ;; crx*) |