diff options
author | Christopher Faylor <me@cgf.cx> | 2012-05-12 23:17:17 +0400 |
---|---|---|
committer | Christopher Faylor <me@cgf.cx> | 2012-05-12 23:17:17 +0400 |
commit | 348b56b5a34e2037b98c30f229b16d1a7468a921 (patch) | |
tree | 3c633c49b16c011dfe1b8548e25493fce6fd5bdd /winsup/cygwin/DevNotes | |
parent | 991addc2617fcfde49ffd3a05e1b26f3cfc7c918 (diff) |
* DevNotes: Add entry cgf-000005.
* fhandler.h (PIPE_ADD_PID): Redefine to something we actually DON'T use.
* pipe.cc (fhandler_pipe::create): Avoid clearing all open_mode bits when
checking for PIPE_ADD_PID. Properly keep track of len so that passed in name
is not overwritten.
Diffstat (limited to 'winsup/cygwin/DevNotes')
-rw-r--r-- | winsup/cygwin/DevNotes | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/winsup/cygwin/DevNotes b/winsup/cygwin/DevNotes index 11a01df57..5ad1ab8a2 100644 --- a/winsup/cygwin/DevNotes +++ b/winsup/cygwin/DevNotes @@ -1,3 +1,22 @@ +2012-05-12 cgf-000005 + +<1.7.16> +- Fix pipe creation problem which manifested as a problem creating a +fifo. Fixes: http://cygwin.com/ml/cygwin/2012-05/msg00253.html +</1.7.16> + +My change on 2012-04-28 introduced a problem with fifos. The passed +in name was overwritten. This was because I wasn't properly keeping +track of the length of the generated pipe name when there was a +name passed in to fhandler_pipe::create. + +There was also another problem in fhandler_pipe::create. Since fifos +use PIPE_ACCESS_DUPLEX and PIPE_ACCESS_DUPLEX is an or'ing of +PIPE_ACCESS_INBOUND and PIPE_ACCESS_OUTBOUND, using PIPE_ACCESS_OUTBOUND +as a "never-used" option for PIPE_ADD_PID in fhandler.h was wrong. So, +fifo creation attempted to add the pid of a pipe to the name which is +wrong for fifos. + 2012-05-08 cgf-000004 The change for cgf-000003 introduced a new problem: |