* dll_init.h (class dll_list): Reorder functions to avoid compiler "can't

inline" warnings.
* security.h (class cygsid): Ditto.
* sigproc.cc (get_proc_lock): Ditto.
* sigproc.h (class sigframe): Ditto.
* sync.h (class muto): Ditto.
* fhandler.h (fhandler_base::get_guard): Actually MAKE virtual as previously
indicated.
* pipe.cc (make_pipe): Remove extraneous set_errno.
* syscalls.cc (_open): Ditto.
* select.cc (peek_pipe): Need to check that there is still something to read
from the pipe after acquiring the mutex since another process/thread could have
eaten the input before we got to acquiring the lock.  (Thanks to Nick Duffek
for this inspiration.)

1 files changed, 9 insertions, 9 deletions

diff --git a/winsup/cygwin/security.h b/winsup/cygwin/security.h
index 95f97b8ca..53c94c8f9 100644
--- a/winsup/cygwin/security.h
+++ b/winsup/cygwin/security.h
@@ -39,6 +39,15 @@ class cygsid {
     }
 
 public:
+  inline operator const PSID () { return psid; }
+
+  inline const PSID operator= (cygsid &nsid)
+    { return assign (nsid); }
+  inline const PSID operator= (const PSID nsid)
+    { return assign (nsid); }
+  inline const PSID operator= (const char *nsidstr)
+    { return getfromstr (nsidstr); }
+
   inline cygsid () : psid ((PSID) sbuf) {}
   inline cygsid (const PSID nsid) { *this = nsid; }
   inline cygsid (const char *nstrsid) { *this = nstrsid; }
@@ -54,13 +63,6 @@ public:
 
   char *string (char *nsidstr) const;
 
-  inline const PSID operator= (cygsid &nsid)
-    { return assign (nsid); }
-  inline const PSID operator= (const PSID nsid)
-    { return assign (nsid); }
-  inline const PSID operator= (const char *nsidstr)
-    { return getfromstr (nsidstr); }
-
   inline BOOL operator== (const PSID nsid) const
     {
       if (!psid || !nsid)
@@ -77,8 +79,6 @@ public:
   inline BOOL operator!= (const char *nsidstr) const
     { return !(*this == nsidstr); }
 
-  inline operator const PSID () { return psid; }
-
   void debug_print (const char *prefix = NULL) const
     {
       char buf[256];