Welcome to mirror list, hosted at ThFree Co, Russian Federation.

cygwin.com/git/newlib-cygwin.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Pfaff <tpfaff@gmx.net>2003-04-16 00:14:12 +0400
committerThomas Pfaff <tpfaff@gmx.net>2003-04-16 00:14:12 +0400
commitffb576fbf2440548e717bf7f37b3aafa48ee2fbc (patch)
treeaeb62e60f0b07c0306c3f0e7a5ae7d5a03e216b8 /winsup/cygwin/thread.cc
parentcfd2c7bea8bcc4d04a1ace959fed7fd2e1ba3784 (diff)
Fix a race in pthread_rwlock caused by simultanoues unlock and cancelation.
* thread.h (pthread_rwlock::release): New method. * thread.cc (pthread_rwlock::unlock): Use release to signal waiting threads. (pthread_rwlock::rdlock_cleanup): Signal waiting threads after a cancelation. (pthread_rwlock::wrlock_cleanup): Ditto.
Diffstat (limited to 'winsup/cygwin/thread.cc')
-rw-r--r--winsup/cygwin/thread.cc10
1 files changed, 3 insertions, 7 deletions
diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
index 0eadd03c5..5f0917ad6 100644
--- a/winsup/cygwin/thread.cc
+++ b/winsup/cygwin/thread.cc
@@ -1210,13 +1210,7 @@ pthread_rwlock::unlock ()
delete reader;
}
- if (waiting_writers)
- {
- if (!readers)
- cond_writers.unblock (false);
- }
- else if (waiting_readers)
- cond_readers.unblock (true);
+ release ();
DONE:
mtx.unlock ();
@@ -1263,6 +1257,7 @@ pthread_rwlock::rdlock_cleanup (void *arg)
pthread_rwlock *rwlock = (pthread_rwlock *) arg;
--(rwlock->waiting_readers);
+ rwlock->release ();
rwlock->mtx.unlock ();
}
@@ -1272,6 +1267,7 @@ pthread_rwlock::wrlock_cleanup (void *arg)
pthread_rwlock *rwlock = (pthread_rwlock *) arg;
--(rwlock->waiting_writers);
+ rwlock->release ();
rwlock->mtx.unlock ();
}