diff options
| author | Corinna Vinschen <corinna@vinschen.de> | 2007-01-31 00:53:05 +0300 |
|---|---|---|
| committer | Corinna Vinschen <corinna@vinschen.de> | 2007-01-31 00:53:05 +0300 |
| commit | 62d172bb493a8183b4c50ed8cc719683086b6a48 (patch) | |
| tree | 05fb2f851c48642504d26e14935dbd29ab7c05f7 /winsup | |
| parent | c7cd7849748c71ee9ef47a6bbbf43a281fe49ce4 (diff) | |
* sigproc.cc (child_info::child_info): Set msv_count to non-zero
value only on systems requiring it.
Diffstat (limited to 'winsup')
| -rw-r--r-- | winsup/cygwin/ChangeLog | 5 | ||||
| -rw-r--r-- | winsup/cygwin/sigproc.cc | 6 |
2 files changed, 8 insertions, 3 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 86cd170b2..e6e2131cb 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,8 @@ +2007-01-30 Corinna Vinschen <corinna@vinschen.de> + + * sigproc.cc (child_info::child_info): Set msv_count to non-zero + value only on systems requiring it. + 2007-01-28 Corinna Vinschen <corinna@vinschen.de> * include/ftw.h: Include sys/cdefs.h. diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc index a8d4a3321..56f9622f5 100644 --- a/winsup/cygwin/sigproc.cc +++ b/winsup/cygwin/sigproc.cc @@ -804,14 +804,14 @@ child_info::child_info (unsigned in_cb, child_info_types chtype, bool need_subpr count doesn't result in trying to evaluate the content, so we do this really only for Vista 64 for now. - However, since this doesn't seem to harm normal windows operation we'll - just set it unconditionally until we hear complaints. + Note: It turns out that a non-zero value *does* harm operation on + XP 64 and 2K3 64 (Crash in CreateProcess call). The value is sizeof (child_info_*) / 5 which results in a count which covers the full datastructure, plus not more than 4 extra bytes. This is ok as long as the child_info structure is cosily stored within a bigger datastructure. */ - msv_count = in_cb / 5; + msv_count = wincap.needs_count_in_si_lpres2 () ? in_cb / 5 : 0; intro = PROC_MAGIC_GENERIC; magic = CHILD_INFO_MAGIC; |