From ac5e8cb29c19dcd286d78ad5cfa84dd6bcbf63d1 Mon Sep 17 00:00:00 2001 From: Jim Blandy Date: Thu, 15 May 2003 19:08:25 +0000 Subject: libiberty/ChangeLog: 2003-05-14 Jim Blandy * hex.c (_hex_value): Make this unsigned. (hex_value): Update documentation for new return type. hex_value now expands to an unsigned int expression, to avoid unexpected sign extension when we store it in a bfd_vma, which is larger than int on some platforms. * functions.texi: Regenerated. include/ChangeLog: 2003-05-14 Jim Blandy * libiberty.h (hex_value): Make the value an unsigned int, to avoid unexpected sign-extension when cast to unsigned types larger than int --- like bfd_vma, on some platforms. (_hex_value): Update declaration. --- include/libiberty.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'include/libiberty.h') diff --git a/include/libiberty.h b/include/libiberty.h index 676ceaba4..761b2cf06 100644 --- a/include/libiberty.h +++ b/include/libiberty.h @@ -254,12 +254,12 @@ extern double physmem_available PARAMS ((void)); #define _hex_array_size 256 #define _hex_bad 99 -extern const char _hex_value[_hex_array_size]; +extern const unsigned char _hex_value[_hex_array_size]; extern void hex_init PARAMS ((void)); #define hex_p(c) (hex_value (c) != _hex_bad) /* If you change this, note well: Some code relies on side effects in the argument being performed exactly once. */ -#define hex_value(c) (_hex_value[(unsigned char) (c)]) +#define hex_value(c) ((unsigned int) _hex_value[(unsigned char) (c)]) /* Definitions used by the pexecute routine. */ -- cgit v1.2.3