From 38042584f3d85018bf43458fda4e4901398d65f9 Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Wed, 15 Dec 2010 13:56:32 +0000 Subject: * security.cc (alloc_sd): Fix erroneous inheritence entry duplication. --- winsup/cygwin/security.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'winsup/cygwin/security.cc') diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc index 509bd1ab0..cddb3f173 100644 --- a/winsup/cygwin/security.cc +++ b/winsup/cygwin/security.cc @@ -648,8 +648,7 @@ alloc_sd (path_conv &pc, __uid32_t uid, __gid32_t gid, int attribute, if ((ace_sid == cur_owner_sid) || (ace_sid == owner_sid) || (ace_sid == cur_group_sid) - || (ace_sid == group_sid) - || (ace_sid == well_known_world_sid)) + || (ace_sid == group_sid)) { if (ace->Header.AceFlags & (CONTAINER_INHERIT_ACE | OBJECT_INHERIT_ACE)) @@ -657,7 +656,11 @@ alloc_sd (path_conv &pc, __uid32_t uid, __gid32_t gid, int attribute, else continue; } - else if (attribute & S_JUSTCREATED) + else if ((ace_sid == well_known_creator_owner_sid) + || (ace_sid == well_known_creator_group_sid) + || (ace_sid == well_known_world_sid)) + continue; + if (attribute & S_JUSTCREATED) { /* Since files and dirs are created with a NULL descriptor, inheritence rules kick in. If no inheritable entries exist -- cgit v1.2.3