diff options
author | Stephan Erb <steve-e@h3c.de> | 2009-11-10 01:03:16 +0300 |
---|---|---|
committer | Stephan Erb <steve-e@h3c.de> | 2009-11-10 01:03:16 +0300 |
commit | ba9ef8301b3da9d751a65bc9f56207922719b192 (patch) | |
tree | f159912f7bac896f8693046a5940600fa14a1d4b | |
parent | 004619f99e3e41762febc1503982d70886e84fa8 (diff) |
Remove superfluous clear_contacts method
-rw-r--r-- | src/common/contacts.py | 3 | ||||
-rw-r--r-- | test/integration/test_gui_event_integration.py | 11 | ||||
-rw-r--r-- | test/integration/test_roster.py | 18 |
3 files changed, 11 insertions, 21 deletions
diff --git a/src/common/contacts.py b/src/common/contacts.py index 7f6f0dc0c..bcb3331ba 100644 --- a/src/common/contacts.py +++ b/src/common/contacts.py @@ -298,9 +298,6 @@ class Contacts: if len(self._contacts[account][contact.jid]) == 0: del self._contacts[account][contact.jid] - def clear_contacts(self, account): - self._contacts[account] = {} - def remove_jid(self, account, jid, remove_meta=True): '''Removes all contacts for a given jid''' if account not in self._contacts: diff --git a/test/integration/test_gui_event_integration.py b/test/integration/test_gui_event_integration.py index 00ed5c696..8759e2259 100644 --- a/test/integration/test_gui_event_integration.py +++ b/test/integration/test_gui_event_integration.py @@ -7,6 +7,7 @@ import lib lib.setup_env() from common import gajim +from common import contacts as contacts_module from gajim import Interface from gajim_mocks import * @@ -25,6 +26,9 @@ class TestStatusChange(unittest.TestCase): '''tests gajim.py's incredibly complex handle_event_notify''' def setUp(self): + + gajim.connections = {} + gajim.contacts = contacts_module.Contacts() gajim.interface.roster = roster_window.RosterWindow() for acc in contacts: @@ -38,13 +42,6 @@ class TestStatusChange(unittest.TestCase): self.assertEqual(0, len(notify.notifications)) def tearDown(self): - gajim.interface.roster.model.clear() - - for acc in contacts: - gajim.contacts.clear_contacts(acc) - - del gajim.interface.roster - notify.notifications = [] def contact_comes_online(self, account, jid, resource, prio): diff --git a/test/integration/test_roster.py b/test/integration/test_roster.py index d093d0e64..acb91b71c 100644 --- a/test/integration/test_roster.py +++ b/test/integration/test_roster.py @@ -9,15 +9,16 @@ from mock import Mock, expectParams from gajim_mocks import * from common import gajim +from common import contacts as contacts_module import roster_window gajim.get_jid_from_account = lambda acc: 'myjid@' + acc + class TestRosterWindow(unittest.TestCase): def setUp(self): gajim.interface = MockInterface() - self.roster = roster_window.RosterWindow() self.C_NAME = roster_window.C_NAME self.C_TYPE = roster_window.C_TYPE @@ -26,13 +27,13 @@ class TestRosterWindow(unittest.TestCase): # Add after creating RosterWindow # We want to test the filling explicitly + gajim.contacts = contacts_module.Contacts() + gajim.connections = {} + self.roster = roster_window.RosterWindow() + for acc in contacts: gajim.connections[acc] = MockConnection(acc) - - def tearDown(self): - self.roster.model.clear() - for acc in gajim.contacts.get_accounts(): - gajim.contacts.clear_contacts(acc) + gajim.contacts.add_account(acc) ### Custom assertions def assert_all_contacts_are_in_roster(self, acc): @@ -142,11 +143,6 @@ class TestRosterWindow(unittest.TestCase): groups = contacts[acc][jid]['groups'] or ['General',] - # cleanup - self.roster.model.clear() - for acc in contacts: - gajim.contacts.clear_contacts(acc) - def test_fill_roster_model(self): for acc in contacts: self.roster.fill_contacts_and_groups_dicts(contacts[acc], acc) |