diff options
| author | Peter Kim <pk15950@gmail.com> | 2021-12-07 14:54:20 +0300 |
|---|---|---|
| committer | Philipp Oeser <info@graphics-engineer.com> | 2022-01-11 12:41:45 +0300 |
| commit | 183f92c7d5fa96dbb017dd383fbd0994bf94a3b0 (patch) | |
| tree | b191a7695dcc39b352623dd953785570af89c885 | |
| parent | f8a51ea60a533bd8158d93bd0ef394a61fc96a85 (diff) | |
Fix T93509: Unintended navigation on Valve Index
The input bindings for "grab" navigation on the Valve Index controllers
could previously trigger the action even when the user did not intend
to do so (i.e. their hand was not actively gripping the sensor). This
was resolved by changing the bindings from "/input/squeeze/value" to
"/input/squeeze/force" and increasing the input threshold from 0.3 to
0.5.
Thanks to sybren for testing.
| -rw-r--r-- | viewport_vr_preview/configs/default.py | 2 | ||||
| -rw-r--r-- | viewport_vr_preview/defaults.py | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/viewport_vr_preview/configs/default.py b/viewport_vr_preview/configs/default.py index efb130c1..f7a50162 100644 --- a/viewport_vr_preview/configs/default.py +++ b/viewport_vr_preview/configs/default.py @@ -54,7 +54,7 @@ actionconfig_data = \ {"bindings": [("cosmos", {"profile": '/interaction_profiles/htc/vive_cosmos_controller', "component_path0": '/input/squeeze/click', "component_path1": '/input/squeeze/click', "threshold": '0.30000001192092896', "axis_region": 'ANY'}), ("huawei", {"profile": '/interaction_profiles/huawei/controller', "component_path0": '/input/trackpad/click', "component_path1": '/input/trackpad/click', "threshold": '0.30000001192092896', "axis_region": 'ANY'}), - ("index", {"profile": '/interaction_profiles/valve/index_controller', "component_path0": '/input/squeeze/value', "component_path1": '/input/squeeze/value', "threshold": '0.30000001192092896', "axis_region": 'ANY'}), + ("index", {"profile": '/interaction_profiles/valve/index_controller', "component_path0": '/input/squeeze/force', "component_path1": '/input/squeeze/force', "threshold": '0.5', "axis_region": 'ANY'}), ("oculus", {"profile": '/interaction_profiles/oculus/touch_controller', "component_path0": '/input/squeeze/value', "component_path1": '/input/squeeze/value', "threshold": '0.30000001192092896', "axis_region": 'ANY'}), ("reverb_g2", {"profile": '/interaction_profiles/hp/mixed_reality_controller', "component_path0": '/input/squeeze/value', "component_path1": '/input/squeeze/value', "threshold": '0.30000001192092896', "axis_region": 'ANY'}), ("simple", {"profile": '/interaction_profiles/khr/simple_controller', "component_path0": '/input/menu/click', "component_path1": '/input/menu/click', "threshold": '0.30000001192092896', "axis_region": 'ANY'}), diff --git a/viewport_vr_preview/defaults.py b/viewport_vr_preview/defaults.py index 205e39d2..33931162 100644 --- a/viewport_vr_preview/defaults.py +++ b/viewport_vr_preview/defaults.py @@ -453,9 +453,9 @@ def vr_defaults_create_default(session_state): vr_defaults_actionbinding_add(ami, VRDefaultActionbindings.INDEX.value, VRDefaultActionprofiles.INDEX.value, - "/input/squeeze/value", - "/input/squeeze/value", - 0.3, + "/input/squeeze/force", + "/input/squeeze/force", + 0.5, 'ANY', 'ANY') vr_defaults_actionbinding_add(ami, |