From 94ebaf04922906924e26761b9cf408daf34c6aeb Mon Sep 17 00:00:00 2001 From: Jesse Yurkovich Date: Sat, 13 Aug 2022 17:36:46 -0700 Subject: Fix T93189: Missing UNDO operator options for Curve Tools addon A variety of operators were missing appropriate bl_options for correct undo support. This results in either crashes (auto loft, bi-rail) or other odd behaviors around returning the scene to the correct previous state (sometimes having to hit ctrl-z twice to undo once, sometimes undo skips steps, etc.) Differential Revision: https://developer.blender.org/D13283 --- curve_tools/auto_loft.py | 1 + curve_tools/operators.py | 9 +++++++++ curve_tools/splines_sequence.py | 1 + 3 files changed, 11 insertions(+) diff --git a/curve_tools/auto_loft.py b/curve_tools/auto_loft.py index 3092e6b8..b14aaf3b 100644 --- a/curve_tools/auto_loft.py +++ b/curve_tools/auto_loft.py @@ -12,6 +12,7 @@ class OperatorAutoLoftCurves(Operator): bl_idname = "curvetools.create_auto_loft" bl_label = "Loft" bl_description = "Lofts selected curves" + bl_options = {'UNDO'} @classmethod def poll(cls, context): diff --git a/curve_tools/operators.py b/curve_tools/operators.py index e4480f88..d4ada318 100644 --- a/curve_tools/operators.py +++ b/curve_tools/operators.py @@ -145,6 +145,7 @@ class OperatorOriginToSpline0Start(bpy.types.Operator): bl_idname = "curvetools.operatororigintospline0start" bl_label = "OriginToSpline0Start" bl_description = "Sets the origin of the active/selected curve to the starting point of the (first) spline. Nice for curve modifiers" + bl_options = {'UNDO'} @classmethod @@ -182,6 +183,7 @@ class OperatorIntersectCurves(bpy.types.Operator): bl_idname = "curvetools.operatorintersectcurves" bl_label = "Intersect" bl_description = "Intersects selected curves" + bl_options = {'UNDO'} @classmethod @@ -233,6 +235,7 @@ class OperatorLoftCurves(bpy.types.Operator): bl_idname = "curvetools.operatorloftcurves" bl_label = "Loft" bl_description = "Lofts selected curves" + bl_options = {'UNDO'} @classmethod @@ -258,6 +261,7 @@ class OperatorSweepCurves(bpy.types.Operator): bl_idname = "curvetools.operatorsweepcurves" bl_label = "Sweep" bl_description = "Sweeps the active curve along to other curve (rail)" + bl_options = {'UNDO'} @classmethod @@ -283,6 +287,7 @@ class OperatorBirail(bpy.types.Operator): bl_idname = "curvetools.operatorbirail" bl_label = "Birail" bl_description = "Generates a birailed surface from 3 selected curves -- in order: rail1, rail2 and profile" + bl_options = {'UNDO'} @classmethod @@ -306,6 +311,7 @@ class OperatorSplinesSetResolution(bpy.types.Operator): bl_idname = "curvetools.operatorsplinessetresolution" bl_label = "SplinesSetResolution" bl_description = "Sets the resolution of all splines" + bl_options = {'UNDO'} @classmethod @@ -330,6 +336,7 @@ class OperatorSplinesRemoveZeroSegment(bpy.types.Operator): bl_idname = "curvetools.operatorsplinesremovezerosegment" bl_label = "SplinesRemoveZeroSegment" bl_description = "Removes splines with no segments -- they seem to creep up, sometimes" + bl_options = {'UNDO'} @classmethod @@ -364,6 +371,7 @@ class OperatorSplinesRemoveShort(bpy.types.Operator): bl_idname = "curvetools.operatorsplinesremoveshort" bl_label = "SplinesRemoveShort" bl_description = "Removes splines with a length smaller than the threshold" + bl_options = {'UNDO'} @classmethod @@ -393,6 +401,7 @@ class OperatorSplinesJoinNeighbouring(bpy.types.Operator): bl_idname = "curvetools.operatorsplinesjoinneighbouring" bl_label = "SplinesJoinNeighbouring" bl_description = "Joins neighbouring splines within a distance smaller than the threshold" + bl_options = {'UNDO'} @classmethod diff --git a/curve_tools/splines_sequence.py b/curve_tools/splines_sequence.py index 2588b5d3..89b9624c 100644 --- a/curve_tools/splines_sequence.py +++ b/curve_tools/splines_sequence.py @@ -214,6 +214,7 @@ class RearrangeSpline(bpy.types.Operator): bl_idname = "curvetools.rearrange_spline" bl_label = "Rearrange Spline" bl_description = "Rearrange Spline" + bl_options = {'UNDO'} Types = [('NEXT', "Next", "next"), ('PREV', "Prev", "prev")] -- cgit v1.2.3