From 12db4f3eae0981607d5fe35007ef134687b19b95 Mon Sep 17 00:00:00 2001 From: Ton Roosendaal Date: Thu, 2 May 2013 15:10:24 +0000 Subject: Revert fix for #34822 Allowing any-key modifiers to work is cool, but this needs more work. My previous fix made overlapping key presses (where you release key 1 just after pressing key 2) to not register as valid shortcuts. --- source/blender/windowmanager/intern/wm_event_system.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/blender/windowmanager/intern/wm_event_system.c b/source/blender/windowmanager/intern/wm_event_system.c index e104da6c067..f79ac1c9083 100644 --- a/source/blender/windowmanager/intern/wm_event_system.c +++ b/source/blender/windowmanager/intern/wm_event_system.c @@ -1384,9 +1384,9 @@ static int wm_eventmatch(wmEvent *winevent, wmKeyMapItem *kmi) if (kmi->oskey != KM_ANY) if (winevent->oskey != kmi->oskey && !(winevent->oskey & kmi->oskey)) return 0; - /* key modifiers always check when event has it */ - /* otherwise regular keypresses with keymodifier still work */ - if (winevent->keymodifier || kmi->keymodifier) + /* only keymap entry with keymodifier is checked, means all keys without modifier get handled too. */ + /* that is currently needed to make overlapping events work (when you press A - G fast or so). */ + if (kmi->keymodifier) if (winevent->keymodifier != kmi->keymodifier) return 0; return 1; -- cgit v1.2.3