From 343fc38b8d646735f42c88dd9de8a33feaf3cb7f Mon Sep 17 00:00:00 2001 From: Antonio Vazquez Date: Tue, 29 Mar 2022 11:25:18 +0200 Subject: Fix T96799: GPencil `weight_get` API cannot retrieve weights The problem was when the stroke had less weights that the total number of vertex groups. The API checked the total number of groups, but this is not required because `BKE_defvert_find_index` returns NULL is the vertex group index does not exist. --- source/blender/makesrna/intern/rna_gpencil.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/blender/makesrna/intern/rna_gpencil.c b/source/blender/makesrna/intern/rna_gpencil.c index 3f380cd1830..63afff73e47 100644 --- a/source/blender/makesrna/intern/rna_gpencil.c +++ b/source/blender/makesrna/intern/rna_gpencil.c @@ -849,10 +849,10 @@ static float rna_GPencilStrokePoints_weight_get(bGPDstroke *stroke, } MDeformVert *pt_dvert = stroke->dvert + point_index; - if ((pt_dvert) && (pt_dvert->totweight <= vertex_group_index || vertex_group_index < 0)) { - BKE_report(reports, RPT_ERROR, "Groups: index out of range"); - return -1.0f; - } + // if ((pt_dvert) && (pt_dvert->totweight <= vertex_group_index || vertex_group_index < 0)) { + // BKE_report(reports, RPT_ERROR, "Groups: index out of range"); + // return -1.0f; + // } MDeformWeight *dw = BKE_defvert_find_index(pt_dvert, vertex_group_index); if (dw) { -- cgit v1.2.3