From 372dcacbe4f3131115166c725820305a6823a5e1 Mon Sep 17 00:00:00 2001 From: Ray Molenkamp Date: Wed, 11 Mar 2020 14:07:47 -0600 Subject: Windows: Cleanup warning about non returning dtor `google::LogMessageFatal::~LogMessageFatal` calls `abort` which MSVC correctly identifies as 'not returning' and warns about a potential memory leak. Given this is intended behaviour and glog is not overly concerned with shutting down the process nicely, we can safely ignore this warning. --- extern/glog/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/extern/glog/CMakeLists.txt b/extern/glog/CMakeLists.txt index c60e30d0b48..d7ad04435e8 100644 --- a/extern/glog/CMakeLists.txt +++ b/extern/glog/CMakeLists.txt @@ -77,6 +77,9 @@ if(WIN32) list(APPEND INC src/windows ) + # Repress warning about google::LogMessageFatal::~LogMessageFatal + # not returning. + add_definitions("/wd4722") else() list(APPEND INC include -- cgit v1.2.3