From 5804bf25bdfe2a29f8c763ab1015e89752baa195 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Thu, 14 Jan 2021 10:30:28 +1100 Subject: Fix uninitialized stack memory use accessing the snap normal Using the add-object tool, snapping to object types such as curve, armature ... etc, copied uninitialized stack memory. --- source/blender/editors/transform/transform_snap_object.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source/blender/editors/transform/transform_snap_object.c b/source/blender/editors/transform/transform_snap_object.c index 50b7c6d147b..b610369f82d 100644 --- a/source/blender/editors/transform/transform_snap_object.c +++ b/source/blender/editors/transform/transform_snap_object.c @@ -3026,7 +3026,11 @@ static short transform_snap_context_project_view3d_mixed_impl( bool has_hit = false; Object *ob = NULL; - float loc[3], no[3], obmat[4][4]; + float loc[3]; + /* Not all snapping callbacks set the normal, + * initialize this since any hit copies both the `loc` and `no`. */ + float no[3] = {0.0f, 0.0f, 0.0f}; + float obmat[4][4]; int index = -1; const ARegion *region = sctx->v3d_data.region; -- cgit v1.2.3