From 5aee4ba1433094e586ef873de734ae90f1622c0f Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Tue, 11 May 2021 11:13:28 +1000 Subject: Fix memory leak in Python IDproperty iterator Looping over IDProperty keys or calling iteritems leaked memory. Error in original Python idproperty support from 8768707610fbc1cea2bde069cdfd6d3f3e2fc522 --- source/blender/python/generic/idprop_py_api.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/source/blender/python/generic/idprop_py_api.c b/source/blender/python/generic/idprop_py_api.c index c329ea7965c..88abae39e2a 100644 --- a/source/blender/python/generic/idprop_py_api.c +++ b/source/blender/python/generic/idprop_py_api.c @@ -760,7 +760,6 @@ static PyObject *BPy_IDGroup_iter(BPy_IDProperty *self) iter->group = self; iter->mode = IDPROP_ITER_KEYS; iter->cur = self->prop->data.group.first; - Py_XINCREF(iter); return (PyObject *)iter; } @@ -933,7 +932,6 @@ static PyObject *BPy_IDGroup_iter_items(BPy_IDProperty *self) iter->group = self; iter->mode = IDPROP_ITER_ITEMS; iter->cur = self->prop->data.group.first; - Py_XINCREF(iter); return (PyObject *)iter; } -- cgit v1.2.3