From 5cd33108fc8af030e519fbf6c3d0bdc541790b3d Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Sat, 13 Mar 2021 21:46:12 -0500 Subject: Cleanup: Remove unused includes, change switch to if --- .../nodes/node_geo_mesh_primitive_circle.cc | 59 +++++++++------------- .../geometry/nodes/node_geo_mesh_primitive_cone.cc | 3 -- .../nodes/node_geo_mesh_primitive_cylinder.cc | 3 -- .../nodes/node_geo_mesh_primitive_uv_sphere.cc | 3 -- 4 files changed, 25 insertions(+), 43 deletions(-) diff --git a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc index 78549abcc46..43cba67c509 100644 --- a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc @@ -14,9 +14,6 @@ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ -#include "BLI_map.hh" -#include "BLI_math_matrix.h" - #include "DNA_mesh_types.h" #include "DNA_meshdata_types.h" @@ -170,38 +167,32 @@ static Mesh *create_circle_mesh(const float radius, } /* Create corners and faces. */ - switch (fill_type) { - case GEO_NODE_MESH_CIRCLE_FILL_NONE: - break; - case GEO_NODE_MESH_CIRCLE_FILL_NGON: { - MPoly &poly = polys[0]; - poly.loopstart = 0; - poly.totloop = loops.size(); - - for (const int i : IndexRange(verts_num)) { - MLoop &loop = loops[i]; - loop.e = i; - loop.v = i; - } - break; + if (fill_type == GEO_NODE_MESH_CIRCLE_FILL_NGON) { + MPoly &poly = polys[0]; + poly.loopstart = 0; + poly.totloop = loops.size(); + + for (const int i : IndexRange(verts_num)) { + MLoop &loop = loops[i]; + loop.e = i; + loop.v = i; } - case GEO_NODE_MESH_CIRCLE_FILL_TRIANGLE_FAN: { - for (const int i : IndexRange(verts_num)) { - MPoly &poly = polys[i]; - poly.loopstart = 3 * i; - poly.totloop = 3; - - MLoop &loop_a = loops[3 * i]; - loop_a.e = i; - loop_a.v = i; - MLoop &loop_b = loops[3 * i + 1]; - loop_b.e = verts_num + ((i + 1) % verts_num); - loop_b.v = (i + 1) % verts_num; - MLoop &loop_c = loops[3 * i + 2]; - loop_c.e = verts_num + i; - loop_c.v = verts_num; - } - break; + } + else if (fill_type == GEO_NODE_MESH_CIRCLE_FILL_TRIANGLE_FAN) { + for (const int i : IndexRange(verts_num)) { + MPoly &poly = polys[i]; + poly.loopstart = 3 * i; + poly.totloop = 3; + + MLoop &loop_a = loops[3 * i]; + loop_a.e = i; + loop_a.v = i; + MLoop &loop_b = loops[3 * i + 1]; + loop_b.e = verts_num + ((i + 1) % verts_num); + loop_b.v = (i + 1) % verts_num; + MLoop &loop_c = loops[3 * i + 2]; + loop_c.e = verts_num + i; + loop_c.v = verts_num; } } diff --git a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc index a47b54fac38..756c419c8a6 100644 --- a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc @@ -14,9 +14,6 @@ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ -#include "BLI_map.hh" -#include "BLI_math_matrix.h" - #include "DNA_mesh_types.h" #include "DNA_meshdata_types.h" diff --git a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc index 52bb5c5aa42..994623ad40d 100644 --- a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc @@ -14,9 +14,6 @@ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ -#include "BLI_map.hh" -#include "BLI_math_matrix.h" - #include "DNA_mesh_types.h" #include "DNA_meshdata_types.h" diff --git a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc index 6e0f90792e8..ac0ee0db7d4 100644 --- a/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc @@ -14,9 +14,6 @@ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ -#include "BLI_map.hh" -#include "BLI_math_matrix.h" - #include "DNA_mesh_types.h" #include "DNA_meshdata_types.h" -- cgit v1.2.3