From 63ea8dd156b39eb57b73a953f5ac9ae54b7a447a Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Mon, 9 Feb 2015 22:23:21 +0500 Subject: Initial compilation support with C++11 featureset enabled This commit makes some preliminary fixes and tweaks aimed to make blender compilable with C++11 feature set. This includes: - Build system attribute to enable C++11 featureset. It's for sure default OFF, but easy to enable to have a play around with it and make sure all the stuff is compilable before we go C++11 for real. - Changes in Compositor to use non-named cl_int structure fields. This is because __STRICT_ANSI__ is defined by default by GCC and OpenCL does not use named fields in this case. - Changes to TYPE_CHECK() related on lack of typeof() in C++11 This uses decltype() instead with some trickery to make sure returned type is not a reference. - Changes for auto_ptr in Freestyle This actually conditionally switches between auto_ptr and unique_ptr since auto_ptr is deprecated in C++11. Seems to be not strictly needed but still nice to be ready for such an update anyway/ This all based on changes form depsgraph_refactor branch apart from the weird changes which were made in order to support MinGW compilation. Those parts of change would need to be carefully reviewed again after official move to gcc49 in MinGW. Tested on Linux with GCC-4.7 and Clang-3.5, other platforms are not tested and likely needs some more tweaks. Reviewers: campbellbarton, juicyfruit, mont29, lukastoenne, psy-fi, kjym3 Differential Revision: https://developer.blender.org/D1089 --- CMakeLists.txt | 14 +++++ SConstruct | 7 +++ build_files/scons/tools/btools.py | 7 ++- intern/cycles/util/util_types.h | 18 ++++++- source/blender/blenlib/BLI_compiler_compat.h | 12 +++++ .../blender/compositor/intern/COM_OpenCLDevice.cpp | 4 +- source/blender/freestyle/CMakeLists.txt | 1 + .../view_map/ArbitraryGridDensityProvider.cpp | 14 ++--- .../intern/view_map/ArbitraryGridDensityProvider.h | 8 +-- .../freestyle/intern/view_map/AutoPtrHelper.h | 60 ++++++++++++++++++++++ .../view_map/AverageAreaGridDensityProvider.cpp | 12 ++--- .../view_map/AverageAreaGridDensityProvider.h | 8 +-- .../intern/view_map/GridDensityProvider.h | 9 ++-- .../HeuristicGridDensityProviderFactory.cpp | 32 ++++++------ .../view_map/HeuristicGridDensityProviderFactory.h | 8 +-- .../intern/view_map/Pow23GridDensityProvider.cpp | 12 ++--- .../intern/view_map/Pow23GridDensityProvider.h | 8 +-- .../freestyle/intern/view_map/ViewMapBuilder.cpp | 12 ++--- 18 files changed, 179 insertions(+), 67 deletions(-) create mode 100644 source/blender/freestyle/intern/view_map/AutoPtrHelper.h diff --git a/CMakeLists.txt b/CMakeLists.txt index 5df6d799593..8e54ddc9274 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -440,6 +440,10 @@ if(MSVC) set(CPACK_INSTALL_PREFIX ${CMAKE_GENERIC_PROGRAM_FILES}/${}) endif() +# Experimental support of C++11 +option(WITH_CPP11 "Build with C++11 standard enabled, for development use only!" OFF) +mark_as_advanced(WITH_CPP11) + # avoid using again option_defaults_clear() @@ -2663,6 +2667,16 @@ if(WITH_PYTHON) endif() endif() +if(WITH_CPP11) + if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11") + elseif(MSVC12) + # Nothing special is needed, C++11 features are available by default. + else() + message(FATAL_ERROR "Compiler ${CMAKE_C_COMPILER_ID} is not supported for C++11 build yet") + endif() +endif() + # Include warnings first, so its possible to disable them with user defined flags # eg: -Wno-uninitialized set(CMAKE_C_FLAGS "${C_WARNINGS} ${CMAKE_C_FLAGS} ${PLATFORM_CFLAGS}") diff --git a/SConstruct b/SConstruct index 7305edfe036..00a95b0114b 100644 --- a/SConstruct +++ b/SConstruct @@ -480,6 +480,13 @@ if env['WITH_BF_OPENMP'] == 1: else: env.Append(CCFLAGS=['-fopenmp']) +if env['WITH_BF_CPP11']: + if env['OURPLATFORM'] in ('win32-vc', 'win64-vc'): + # Nothing special is needed, C++11 features are available by default. + pass + else: + env['CXXFLAGS'].append('-std=c++11') + #check for additional debug libnames if env.has_key('BF_DEBUG_LIBS'): diff --git a/build_files/scons/tools/btools.py b/build_files/scons/tools/btools.py index eb5036f9996..c5342d6f349 100644 --- a/build_files/scons/tools/btools.py +++ b/build_files/scons/tools/btools.py @@ -198,7 +198,8 @@ def validate_arguments(args, bc): 'C_WARN', 'CC_WARN', 'CXX_WARN', 'LLIBS', 'PLATFORM_LINKFLAGS', 'MACOSX_ARCHITECTURE', 'MACOSX_SDK', 'XCODE_CUR_VER', 'C_COMPILER_ID', 'BF_CYCLES_CUDA_BINARIES_ARCH', 'BF_PROGRAM_LINKFLAGS', 'MACOSX_DEPLOYMENT_TARGET', - 'WITH_BF_CYCLES_DEBUG', 'WITH_BF_CYCLES_LOGGING' + 'WITH_BF_CYCLES_DEBUG', 'WITH_BF_CYCLES_LOGGING', + 'WITH_BF_CPP11' ] @@ -653,7 +654,9 @@ def read_opts(env, cfg, args): ('BF_LLVM_LIBPATH', 'LLVM library path', ''), ('BF_LLVM_LIB_STATIC', 'LLVM static library', ''), - ('BF_PROGRAM_LINKFLAGS', 'Link flags applied only to final binaries (blender and blenderplayer, not makesrna/makesdna)', '') + ('BF_PROGRAM_LINKFLAGS', 'Link flags applied only to final binaries (blender and blenderplayer, not makesrna/makesdna)', ''), + + (BoolVariable('WITH_BF_CPP11', '"Build with C++11 standard enabled, for development use only!', False)), ) # end of opts.AddOptions() return localopts diff --git a/intern/cycles/util/util_types.h b/intern/cycles/util/util_types.h index df61b6ead21..187675e74bf 100644 --- a/intern/cycles/util/util_types.h +++ b/intern/cycles/util/util_types.h @@ -481,18 +481,32 @@ enum InterpolationType { # define UNLIKELY(x) (x) #endif +#if defined(__cplusplus) && ((__cplusplus >= 201103L) || (defined(_MSC_VER) && _MSC_VER >= 1800)) +# define HAS_CPP11_FEATURES +#endif + +#if defined(__GNUC__) || defined(__clang__) +# if defined(HAS_CPP11_FEATURES) +/* Some magic to be sure we don't have reference in the type. */ +template static inline T decltype_helper(T x) { return x; } +# define TYPEOF(x) decltype(decltype_helper(x)) +# else +# define TYPEOF(x) typeof(x) +# endif +#endif + /* Causes warning: * incompatible types when assigning to type 'Foo' from type 'Bar' * ... the compiler optimizes away the temp var */ #ifdef __GNUC__ #define CHECK_TYPE(var, type) { \ - typeof(var) *__tmp; \ + TYPEOF(var) *__tmp; \ __tmp = (type *)NULL; \ (void)__tmp; \ } (void)0 #define CHECK_TYPE_PAIR(var_a, var_b) { \ - typeof(var_a) *__tmp; \ + TYPEOF(var_a) *__tmp; \ __tmp = (typeof(var_b) *)NULL; \ (void)__tmp; \ } (void)0 diff --git a/source/blender/blenlib/BLI_compiler_compat.h b/source/blender/blenlib/BLI_compiler_compat.h index 10c0752c9a7..876d2c459c5 100644 --- a/source/blender/blenlib/BLI_compiler_compat.h +++ b/source/blender/blenlib/BLI_compiler_compat.h @@ -37,4 +37,16 @@ # include #endif +#if defined(__cplusplus) && ((__cplusplus >= 201103L) || (defined(_MSC_VER) && _MSC_VER >= 1800)) +# define HAS_CPP11_FEATURES +#endif + +#if (defined(__GNUC__) || defined(__clang__)) && defined(HAS_CPP11_FEATURES) +extern "C++" { + /* Some magic to be sure we don't have reference in the type. */ + template static inline T decltype_helper(T x) { return x; } +# define typeof(x) decltype(decltype_helper(x)) +} +#endif + #endif /* __BLI_COMPILER_COMPAT_H__ */ diff --git a/source/blender/compositor/intern/COM_OpenCLDevice.cpp b/source/blender/compositor/intern/COM_OpenCLDevice.cpp index 5960082c2fd..1b7acc9daf6 100644 --- a/source/blender/compositor/intern/COM_OpenCLDevice.cpp +++ b/source/blender/compositor/intern/COM_OpenCLDevice.cpp @@ -180,7 +180,7 @@ void OpenCLDevice::COM_clEnqueueRange(cl_kernel kernel, MemoryBuffer *outputMemo bool breaked = false; for (offsety = 0; offsety < height && (!breaked); offsety += localSize) { - offset.y = offsety; + offset.s[1] = offsety; if (offsety + localSize < height) { size[1] = localSize; } @@ -195,7 +195,7 @@ void OpenCLDevice::COM_clEnqueueRange(cl_kernel kernel, MemoryBuffer *outputMemo else { size[0] = width - offsetx; } - offset.x = offsetx; + offset.s[0] = offsetx; error = clSetKernelArg(kernel, offsetIndex, sizeof(cl_int2), &offset); if (error != CL_SUCCESS) { printf("CLERROR[%d]: %s\n", error, clewErrorString(error)); } diff --git a/source/blender/freestyle/CMakeLists.txt b/source/blender/freestyle/CMakeLists.txt index 7fbb219af08..c14a5c53734 100644 --- a/source/blender/freestyle/CMakeLists.txt +++ b/source/blender/freestyle/CMakeLists.txt @@ -491,6 +491,7 @@ set(SRC intern/system/TimeUtils.h intern/view_map/ArbitraryGridDensityProvider.cpp intern/view_map/ArbitraryGridDensityProvider.h + intern/view_map/AutoPtrHelper.h intern/view_map/AverageAreaGridDensityProvider.cpp intern/view_map/AverageAreaGridDensityProvider.h intern/view_map/BoxGrid.cpp diff --git a/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.cpp b/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.cpp index 8bc7c0952a8..3243c4d1fb7 100644 --- a/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.cpp +++ b/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.cpp @@ -100,22 +100,22 @@ ArbitraryGridDensityProviderFactory::ArbitraryGridDensityProviderFactory(unsigne ArbitraryGridDensityProviderFactory::~ArbitraryGridDensityProviderFactory() {} -auto_ptr ArbitraryGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, - const real proscenium[4]) +AutoPtr ArbitraryGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, + const real proscenium[4]) { - return auto_ptr(new ArbitraryGridDensityProvider(source, proscenium, numCells)); + return AutoPtr(new ArbitraryGridDensityProvider(source, proscenium, numCells)); } -auto_ptr +AutoPtr ArbitraryGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const BBox& bbox, const GridHelpers::Transform& transform) { - return auto_ptr(new ArbitraryGridDensityProvider(source, bbox, transform, numCells)); + return AutoPtr(new ArbitraryGridDensityProvider(source, bbox, transform, numCells)); } -auto_ptr ArbitraryGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) +AutoPtr ArbitraryGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) { - return auto_ptr(new ArbitraryGridDensityProvider(source, numCells)); + return AutoPtr(new ArbitraryGridDensityProvider(source, numCells)); } } /* namespace Freestyle */ diff --git a/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.h b/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.h index 652cb9b34b0..c7939d34da4 100644 --- a/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.h +++ b/source/blender/freestyle/intern/view_map/ArbitraryGridDensityProvider.h @@ -58,10 +58,10 @@ public: ArbitraryGridDensityProviderFactory(unsigned numCells); ~ArbitraryGridDensityProviderFactory(); - auto_ptr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); - auto_ptr newGridDensityProvider(OccluderSource& source, const BBox& bbox, - const GridHelpers::Transform& transform); - auto_ptr newGridDensityProvider(OccluderSource& source); + AutoPtr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); + AutoPtr newGridDensityProvider(OccluderSource& source, const BBox& bbox, + const GridHelpers::Transform& transform); + AutoPtr newGridDensityProvider(OccluderSource& source); protected: unsigned numCells; diff --git a/source/blender/freestyle/intern/view_map/AutoPtrHelper.h b/source/blender/freestyle/intern/view_map/AutoPtrHelper.h new file mode 100644 index 00000000000..17a43c184c7 --- /dev/null +++ b/source/blender/freestyle/intern/view_map/AutoPtrHelper.h @@ -0,0 +1,60 @@ +/* + * ***** BEGIN GPL LICENSE BLOCK ***** + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + * + * ***** END GPL LICENSE BLOCK ***** + */ + +#ifndef __FREESTYLE_AUTOPTR_HELPER_H__ +#define __FREESTYLE_AUTOPTR_HELPER_H__ + +/** \file blender/freestyle/intern/view_map/AutoPtrHelper.h + * \ingroup freestyle + * \brief Utility header for auto_ptr/unique_ptr selection + * \author Sergey Sharybin + * \date 2015-02-09 + */ + +#include + +namespace Freestyle { + +#if __cplusplus > 199711L +template +class AutoPtr : public std::unique_ptr { +public: + AutoPtr() : std::unique_ptr() {} + AutoPtr(T *ptr) : std::unique_ptr(ptr) {} + + /* TODO(sergey): Is there more clear way to do this? */ + template + AutoPtr(AutoPtr& other) : std::unique_ptr(other.get()) { + other.release(); + } +}; +#else +template +class AutoPtr : public std::auto_ptr { +public: + AutoPtr() : std::auto_ptr() {} + AutoPtr(T *ptr) : std::auto_ptr(ptr) {} + AutoPtr(std::auto_ptr_ref ref) : std::auto_ptr(ref) {} +}; +#endif + +} /* namespace Freestyle */ + +#endif // __FREESTYLE_AUTOPTR_HELPER_H__ diff --git a/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.cpp b/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.cpp index 952b9752a3e..b5e133ec441 100644 --- a/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.cpp +++ b/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.cpp @@ -121,22 +121,22 @@ AverageAreaGridDensityProviderFactory::AverageAreaGridDensityProviderFactory(rea AverageAreaGridDensityProviderFactory::~AverageAreaGridDensityProviderFactory() {} -auto_ptr +AutoPtr AverageAreaGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const real proscenium[4]) { - return auto_ptr(new AverageAreaGridDensityProvider(source, proscenium, sizeFactor)); + return AutoPtr(new AverageAreaGridDensityProvider(source, proscenium, sizeFactor)); } -auto_ptr +AutoPtr AverageAreaGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const BBox& bbox, const GridHelpers::Transform& transform) { - return auto_ptr(new AverageAreaGridDensityProvider(source, bbox, transform, sizeFactor)); + return AutoPtr(new AverageAreaGridDensityProvider(source, bbox, transform, sizeFactor)); } -auto_ptr AverageAreaGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) +AutoPtr AverageAreaGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) { - return auto_ptr(new AverageAreaGridDensityProvider(source, sizeFactor)); + return AutoPtr(new AverageAreaGridDensityProvider(source, sizeFactor)); } } /* namespace Freestyle */ diff --git a/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.h b/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.h index d63557f5cda..2c58cc32da9 100644 --- a/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.h +++ b/source/blender/freestyle/intern/view_map/AverageAreaGridDensityProvider.h @@ -55,10 +55,10 @@ public: AverageAreaGridDensityProviderFactory(real sizeFactor); ~AverageAreaGridDensityProviderFactory(); - auto_ptr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); - auto_ptr newGridDensityProvider(OccluderSource& source, const BBox& bbox, - const GridHelpers::Transform& transform); - auto_ptr newGridDensityProvider(OccluderSource& source); + AutoPtr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); + AutoPtr newGridDensityProvider(OccluderSource& source, const BBox& bbox, + const GridHelpers::Transform& transform); + AutoPtr newGridDensityProvider(OccluderSource& source); protected: real sizeFactor; diff --git a/source/blender/freestyle/intern/view_map/GridDensityProvider.h b/source/blender/freestyle/intern/view_map/GridDensityProvider.h index 272d64dd6de..b49e74d6402 100644 --- a/source/blender/freestyle/intern/view_map/GridDensityProvider.h +++ b/source/blender/freestyle/intern/view_map/GridDensityProvider.h @@ -32,6 +32,7 @@ #include #include +#include "AutoPtrHelper.h" #include "OccluderSource.h" #include "../geometry/BBox.h" @@ -148,12 +149,12 @@ class GridDensityProviderFactory public: GridDensityProviderFactory() {} - virtual auto_ptr newGridDensityProvider(OccluderSource& source, const real proscenium[4]) = 0; + virtual AutoPtr newGridDensityProvider(OccluderSource& source, const real proscenium[4]) = 0; - virtual auto_ptr newGridDensityProvider(OccluderSource& source, const BBox& bbox, - const GridHelpers::Transform& transform) = 0; + virtual AutoPtr newGridDensityProvider(OccluderSource& source, const BBox& bbox, + const GridHelpers::Transform& transform) = 0; - virtual auto_ptr newGridDensityProvider(OccluderSource& source) = 0; + virtual AutoPtr newGridDensityProvider(OccluderSource& source) = 0; virtual ~GridDensityProviderFactory () {} diff --git a/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.cpp b/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.cpp index 00f5cc90cc4..18edc82b096 100644 --- a/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.cpp +++ b/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.cpp @@ -36,45 +36,45 @@ HeuristicGridDensityProviderFactory::HeuristicGridDensityProviderFactory(real si HeuristicGridDensityProviderFactory::~HeuristicGridDensityProviderFactory() {} -auto_ptr +AutoPtr HeuristicGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const real proscenium[4]) { - auto_ptr avg(new AverageAreaGridDensityProvider(source, proscenium, sizeFactor)); - auto_ptr p23(new Pow23GridDensityProvider(source, proscenium, numFaces)); + AutoPtr avg(new AverageAreaGridDensityProvider(source, proscenium, sizeFactor)); + AutoPtr p23(new Pow23GridDensityProvider(source, proscenium, numFaces)); if (avg->cellSize() > p23->cellSize()) { - return (auto_ptr) p23; + return (AutoPtr) p23; } else { - return (auto_ptr) avg; + return (AutoPtr) avg; } } -auto_ptr +AutoPtr HeuristicGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const BBox& bbox, const GridHelpers::Transform& transform) { - auto_ptr avg(new AverageAreaGridDensityProvider(source, bbox, - transform, sizeFactor)); - auto_ptr p23(new Pow23GridDensityProvider(source, bbox, transform, numFaces)); + AutoPtr avg(new AverageAreaGridDensityProvider(source, bbox, + transform, sizeFactor)); + AutoPtr p23(new Pow23GridDensityProvider(source, bbox, transform, numFaces)); if (avg->cellSize() > p23->cellSize()) { - return (auto_ptr) p23; + return (AutoPtr) p23; } else { - return (auto_ptr) avg; + return (AutoPtr) avg; } } -auto_ptr HeuristicGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) +AutoPtr HeuristicGridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) { real proscenium[4]; GridDensityProvider::calculateOptimalProscenium(source, proscenium); - auto_ptr avg(new AverageAreaGridDensityProvider(source, proscenium, sizeFactor)); - auto_ptr p23(new Pow23GridDensityProvider(source, proscenium, numFaces)); + AutoPtr avg(new AverageAreaGridDensityProvider(source, proscenium, sizeFactor)); + AutoPtr p23(new Pow23GridDensityProvider(source, proscenium, numFaces)); if (avg->cellSize() > p23->cellSize()) { - return (auto_ptr) p23; + return (AutoPtr) p23; } else { - return (auto_ptr) avg; + return (AutoPtr) avg; } } diff --git a/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.h b/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.h index 65f2af6df2f..9414e4931f5 100644 --- a/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.h +++ b/source/blender/freestyle/intern/view_map/HeuristicGridDensityProviderFactory.h @@ -42,10 +42,10 @@ public: HeuristicGridDensityProviderFactory(real sizeFactor, unsigned numFaces); ~HeuristicGridDensityProviderFactory(); - auto_ptr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); - auto_ptr newGridDensityProvider(OccluderSource& source, const BBox& bbox, - const GridHelpers::Transform& transform); - auto_ptr newGridDensityProvider(OccluderSource& source); + AutoPtr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); + AutoPtr newGridDensityProvider(OccluderSource& source, const BBox& bbox, + const GridHelpers::Transform& transform); + AutoPtr newGridDensityProvider(OccluderSource& source); protected: real sizeFactor; diff --git a/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.cpp b/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.cpp index e3bb9b87ecc..8dff079e0cf 100644 --- a/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.cpp +++ b/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.cpp @@ -99,22 +99,22 @@ Pow23GridDensityProviderFactory::Pow23GridDensityProviderFactory(unsigned numFac Pow23GridDensityProviderFactory::~Pow23GridDensityProviderFactory () {} -auto_ptr +AutoPtr Pow23GridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const real proscenium[4]) { - return auto_ptr(new Pow23GridDensityProvider(source, proscenium, numFaces)); + return AutoPtr(new Pow23GridDensityProvider(source, proscenium, numFaces)); } -auto_ptr +AutoPtr Pow23GridDensityProviderFactory::newGridDensityProvider(OccluderSource& source, const BBox& bbox, const GridHelpers::Transform& transform) { - return auto_ptr(new Pow23GridDensityProvider(source, bbox, transform, numFaces)); + return AutoPtr(new Pow23GridDensityProvider(source, bbox, transform, numFaces)); } -auto_ptr Pow23GridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) +AutoPtr Pow23GridDensityProviderFactory::newGridDensityProvider(OccluderSource& source) { - return auto_ptr(new Pow23GridDensityProvider(source, numFaces)); + return AutoPtr(new Pow23GridDensityProvider(source, numFaces)); } } /* namespace Freestyle */ diff --git a/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.h b/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.h index 7f646790ab6..5dfa9cdfc87 100644 --- a/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.h +++ b/source/blender/freestyle/intern/view_map/Pow23GridDensityProvider.h @@ -58,10 +58,10 @@ public: Pow23GridDensityProviderFactory(unsigned numFaces); ~Pow23GridDensityProviderFactory(); - auto_ptr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); - auto_ptr newGridDensityProvider(OccluderSource& source, const BBox& bbox, - const GridHelpers::Transform& transform); - auto_ptr newGridDensityProvider(OccluderSource& source); + AutoPtr newGridDensityProvider(OccluderSource& source, const real proscenium[4]); + AutoPtr newGridDensityProvider(OccluderSource& source, const BBox& bbox, + const GridHelpers::Transform& transform); + AutoPtr newGridDensityProvider(OccluderSource& source); protected: unsigned numFaces; diff --git a/source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp b/source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp index a0a1282219c..8adc2fa66fd 100644 --- a/source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp +++ b/source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp @@ -1300,8 +1300,8 @@ void ViewMapBuilder::computeCusps(ViewMap *ioViewMap) void ViewMapBuilder::ComputeCumulativeVisibility(ViewMap *ioViewMap, WingedEdge& we, const BBox& bbox, real epsilon, bool cull, GridDensityProviderFactory& factory) { - auto_ptr transform; - auto_ptr source; + AutoPtr transform; + AutoPtr source; if (_orthographicProjection) { transform.reset(new BoxGrid::Transform); @@ -1317,7 +1317,7 @@ void ViewMapBuilder::ComputeCumulativeVisibility(ViewMap *ioViewMap, WingedEdge& source.reset(new OccluderSource(*transform, we)); } - auto_ptr density(factory.newGridDensityProvider(*source, bbox, *transform)); + AutoPtr density(factory.newGridDensityProvider(*source, bbox, *transform)); if (_orthographicProjection) { BoxGrid grid(*source, *density, ioViewMap, _viewpoint, _EnableQI); @@ -1332,8 +1332,8 @@ void ViewMapBuilder::ComputeCumulativeVisibility(ViewMap *ioViewMap, WingedEdge& void ViewMapBuilder::ComputeDetailedVisibility(ViewMap *ioViewMap, WingedEdge& we, const BBox& bbox, real epsilon, bool cull, GridDensityProviderFactory& factory) { - auto_ptr transform; - auto_ptr source; + AutoPtr transform; + AutoPtr source; if (_orthographicProjection) { transform.reset(new BoxGrid::Transform); @@ -1349,7 +1349,7 @@ void ViewMapBuilder::ComputeDetailedVisibility(ViewMap *ioViewMap, WingedEdge& w source.reset(new OccluderSource(*transform, we)); } - auto_ptr density(factory.newGridDensityProvider(*source, bbox, *transform)); + AutoPtr density(factory.newGridDensityProvider(*source, bbox, *transform)); if (_orthographicProjection) { BoxGrid grid(*source, *density, ioViewMap, _viewpoint, _EnableQI); -- cgit v1.2.3