From dc0bf9b7027783c3a760cc08286213c59db936f0 Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Wed, 29 Dec 2021 00:16:54 -0600 Subject: Fix T94453: Weld modifier crash after recent cleanup I had assumed that the span's size was the same as the length variable. In the future, separate lengths could be removed in favor of using lengths directly from spans. --- source/blender/modifiers/intern/MOD_weld.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/blender/modifiers/intern/MOD_weld.cc b/source/blender/modifiers/intern/MOD_weld.cc index 097ed26afb3..1f7783f8b28 100644 --- a/source/blender/modifiers/intern/MOD_weld.cc +++ b/source/blender/modifiers/intern/MOD_weld.cc @@ -1040,9 +1040,9 @@ static void weld_poly_loop_ctx_setup(Span mloop, if (remain_edge_ctx_len) { - /* Setup Poly/Loop. */ - - for (WeldPoly &wp : wpoly) { + /* Setup Poly/Loop. Note that `wpoly_len` may be different than `wpoly.size()` here. */ + for (const int i : IndexRange(wpoly_len)) { + WeldPoly &wp = wpoly[i]; const int ctx_loops_len = wp.loops.len; const int ctx_loops_ofs = wp.loops.ofs; -- cgit v1.2.3