From b25bb2d7ec31ef08d67142ad655d59cd37e1d747 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Fri, 29 Nov 2019 10:37:43 +0100 Subject: Archive build script: stop when creating archive fails The `subprocess.call()` function doesn't check the exit status code of the subprocess. Use `subprocess.check_call()` or `subprocess.run()` instead. --- build_files/package_spec/build_archive.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'build_files/package_spec') diff --git a/build_files/package_spec/build_archive.py b/build_files/package_spec/build_archive.py index 754bb8cd402..d8d3c29ea48 100755 --- a/build_files/package_spec/build_archive.py +++ b/build_files/package_spec/build_archive.py @@ -61,7 +61,7 @@ try: sys.stderr.write('Unknown archive extension: ' + extension) sys.exit(-1) - subprocess.call(archive_cmd) + subprocess.check_call(archive_cmd, env=archive_env) except Exception as ex: sys.stderr.write('Failed to create package archive: ' + str(ex) + '\n') sys.exit(1) -- cgit v1.2.3