From 1176591574f9ec5ead51c512dbe77c3cc7972d6d Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Tue, 1 Dec 2020 17:16:48 +0100 Subject: Codesign: Allo non-zero exit code for signtool on Windows --- build_files/buildbot/codesign/windows_code_signer.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'build_files') diff --git a/build_files/buildbot/codesign/windows_code_signer.py b/build_files/buildbot/codesign/windows_code_signer.py index 251dd856c8a..db185788a56 100644 --- a/build_files/buildbot/codesign/windows_code_signer.py +++ b/build_files/buildbot/codesign/windows_code_signer.py @@ -64,7 +64,12 @@ class WindowsCodeSigner(BaseCodeSigner): def run_codesign_tool(self, filepath: Path) -> None: command = self.get_sign_command_prefix() + [filepath] - codesign_output = self.check_output_or_mock(command, util.Platform.WINDOWS) + + try: + codesign_output = self.check_output_or_mock(command, util.Platform.WINDOWS) + except subprocess.CalledProcessError as e: + raise SigntoolException(f'Error running signtool {e}') + logger_server.info(f'signtool output:\n{codesign_output}') got_number_of_success = False -- cgit v1.2.3