From 351c409317242857937b16a6d461b59ec6e690e0 Mon Sep 17 00:00:00 2001 From: Phil Christensen <> Date: Mon, 6 Feb 2017 10:44:25 +0100 Subject: C++ conformance fixes (MSVC /permissive-) We (the Microsoft C++ team) use the Blender project as part of our "Real world code" tests. I noticed a place in WIN32 specific code (dvpapi.cpp:85) where a string literal is losing its const-ness when being passed to BLI_dynlib_open(). This is not permitted when using the /permissive- conformance compiler switch (see our blog https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/) My suggested fix is to add const and propagate it where needed. Another possible fix would be to explicitly cast away the const. Reviewers: mont29, sergey, LazyDodo Subscribers: Blendify, sergey, mont29, LazyDodo Tags: #platform:_windows Differential Revision: https://developer.blender.org/D2495 --- intern/utfconv/utfconv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'intern') diff --git a/intern/utfconv/utfconv.h b/intern/utfconv/utfconv.h index f00f4aeef27..d05ed61c8d8 100644 --- a/intern/utfconv/utfconv.h +++ b/intern/utfconv/utfconv.h @@ -93,7 +93,7 @@ wchar_t *alloc_utf16_from_8(const char *in8, size_t add); /* Easy allocation and conversion of new utf-16 string. New string has _16 suffix. Must be deallocated with UTF16_UN_ENCODE in right order*/ #define UTF16_ENCODE(in8str) if (1) { \ - wchar_t *in8str ## _16 = alloc_utf16_from_8((char *)in8str, 0) + wchar_t *in8str ## _16 = alloc_utf16_from_8((const char *)in8str, 0) #define UTF16_UN_ENCODE(in8str) \ free(in8str ## _16); } (void)0 -- cgit v1.2.3