From 3a605b23d02263be6bca9046e20b46a60832d971 Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Wed, 31 Aug 2022 20:09:12 +0200 Subject: Fix T100708: Cycles bake of diffuse/glossy color not outputting alpha --- intern/cycles/integrator/pass_accessor.cpp | 6 ++++++ intern/cycles/kernel/film/read.h | 15 +++++++++++++++ intern/cycles/kernel/integrator/init_from_bake.h | 2 +- 3 files changed, 22 insertions(+), 1 deletion(-) (limited to 'intern') diff --git a/intern/cycles/integrator/pass_accessor.cpp b/intern/cycles/integrator/pass_accessor.cpp index 05318b7545b..ab056e953c2 100644 --- a/intern/cycles/integrator/pass_accessor.cpp +++ b/intern/cycles/integrator/pass_accessor.cpp @@ -191,6 +191,12 @@ bool PassAccessor::get_render_tile_pixels(const RenderBuffers *render_buffers, * had the computation done. */ if (pass_info.num_components == 3) { get_pass_float3(render_buffers, buffer_params, destination); + + /* Use alpha for colors passes. */ + if (type == PASS_DIFFUSE_COLOR || type == PASS_GLOSSY_COLOR || + type == PASS_TRANSMISSION_COLOR) { + num_written_components = destination.num_components; + } } else if (pass_info.num_components == 4) { if (destination.num_components == 3) { diff --git a/intern/cycles/kernel/film/read.h b/intern/cycles/kernel/film/read.h index a0236909f4b..995c20a0053 100644 --- a/intern/cycles/kernel/film/read.h +++ b/intern/cycles/kernel/film/read.h @@ -235,6 +235,21 @@ ccl_device_inline void film_get_pass_pixel_float3(ccl_global const KernelFilmCon pixel[0] = f.x; pixel[1] = f.y; pixel[2] = f.z; + + /* Optional alpha channel. */ + if (kfilm_convert->num_components >= 4) { + if (kfilm_convert->pass_combined != PASS_UNUSED) { + float scale, scale_exposure; + film_get_scale_and_scale_exposure(kfilm_convert, buffer, &scale, &scale_exposure); + + ccl_global const float *in_combined = buffer + kfilm_convert->pass_combined; + const float alpha = in_combined[3] * scale; + pixel[3] = film_transparency_to_alpha(alpha); + } + else { + pixel[3] = 1.0f; + } + } } /* -------------------------------------------------------------------- diff --git a/intern/cycles/kernel/integrator/init_from_bake.h b/intern/cycles/kernel/integrator/init_from_bake.h index dd26215bcd2..c77fc2540c1 100644 --- a/intern/cycles/kernel/integrator/init_from_bake.h +++ b/intern/cycles/kernel/integrator/init_from_bake.h @@ -113,7 +113,7 @@ ccl_device bool integrator_init_from_bake(KernelGlobals kg, if (prim == -1) { /* Accumulate transparency for empty pixels. */ kernel_accum_transparent(kg, state, 0, 1.0f, buffer); - return false; + return true; } prim += kernel_data.bake.tri_offset; -- cgit v1.2.3