From bbc7eb8ae5386aae5aaa58df76f701bc7f0dddbf Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Sun, 29 Oct 2017 15:26:09 +0100 Subject: Cycles: restore SOBOL_SKIP hack, for some cases where it helps still. --- intern/cycles/kernel/kernel_random.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'intern') diff --git a/intern/cycles/kernel/kernel_random.h b/intern/cycles/kernel/kernel_random.h index e7a6134b8eb..7a96806edac 100644 --- a/intern/cycles/kernel/kernel_random.h +++ b/intern/cycles/kernel/kernel_random.h @@ -31,10 +31,17 @@ CCL_NAMESPACE_BEGIN #ifdef __SOBOL__ +/* Skip initial numbers that for some dimensions have clear patterns that + * don't cover the entire sample space. Ideally we would have a better + * progressive pattern that doesn't suffer from this problem, because even + * with this offset some dimensions are quite poor. + */ +#define SOBOL_SKIP 64 + ccl_device uint sobol_dimension(KernelGlobals *kg, int index, int dimension) { uint result = 0; - uint i = index; + uint i = index + SOBOL_SKIP; for(uint j = 0; i; i >>= 1, j++) { if(i & 1) { result ^= kernel_tex_fetch(__sobol_directions, 32*dimension + j); -- cgit v1.2.3