From c986e46be708f6885a9504d87f58a99259ac63c7 Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Mon, 30 Nov 2020 12:21:44 +0100 Subject: Cleanup: avoid harmless but unnecessary float division by zero --- intern/cycles/render/light.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'intern') diff --git a/intern/cycles/render/light.cpp b/intern/cycles/render/light.cpp index 80190dcbf82..2bde3242b26 100644 --- a/intern/cycles/render/light.cpp +++ b/intern/cycles/render/light.cpp @@ -551,17 +551,19 @@ static void background_cdf( cond_cdf[i * cdf_width + j - 1].x / res_x; } - float cdf_total = cond_cdf[i * cdf_width + res_x - 1].y + - cond_cdf[i * cdf_width + res_x - 1].x / res_x; - float cdf_total_inv = 1.0f / cdf_total; + const float cdf_total = cond_cdf[i * cdf_width + res_x - 1].y + + cond_cdf[i * cdf_width + res_x - 1].x / res_x; /* stuff the total into the brightness value for the last entry, because * we are going to normalize the CDFs to 0.0 to 1.0 afterwards */ cond_cdf[i * cdf_width + res_x].x = cdf_total; - if (cdf_total > 0.0f) - for (int j = 1; j < res_x; j++) + if (cdf_total > 0.0f) { + const float cdf_total_inv = 1.0f / cdf_total; + for (int j = 1; j < res_x; j++) { cond_cdf[i * cdf_width + j].y *= cdf_total_inv; + } + } cond_cdf[i * cdf_width + res_x].y = 1.0f; } -- cgit v1.2.3