From 1c2b2037956bf1d46a10842a4b503d20714bdcf2 Mon Sep 17 00:00:00 2001 From: Philipp Oeser Date: Fri, 15 Jan 2021 19:01:57 +0100 Subject: Fix T84600: prevent bone groups operators on proxies and library overrides Editing bone groups is not supported on proxies/overrides [changes a re lost on file reload], need to do proper polling (and also prevent this from rna) for: - adding bone groups - removing bone groups - renaming bone groups - setting bone groups colors Previously, this was hinted at by setting the layout inactive, with preoper polls, this is now not needed anymore. note: Selection of bone groups actually makes sense here and is supported, so this is not prevented in this patch, but UI wise this is not nice in the override case, because one cannot set an active_index (aka select) in the UI list. Maniphest Tasks: T84600 Differential Revision: https://developer.blender.org/D10131 --- release/scripts/startup/bl_ui/properties_data_armature.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'release/scripts/startup/bl_ui') diff --git a/release/scripts/startup/bl_ui/properties_data_armature.py b/release/scripts/startup/bl_ui/properties_data_armature.py index 05abfa02500..4cdcab45926 100644 --- a/release/scripts/startup/bl_ui/properties_data_armature.py +++ b/release/scripts/startup/bl_ui/properties_data_armature.py @@ -133,7 +133,6 @@ class DATA_PT_bone_groups(ArmatureButtonsPanel, Panel): ) col = row.column(align=True) - col.active = (ob.proxy is None) col.operator("pose.group_add", icon='ADD', text="") col.operator("pose.group_remove", icon='REMOVE', text="") col.menu("DATA_MT_bone_group_context_menu", icon='DOWNARROW_HLT', text="") @@ -156,7 +155,6 @@ class DATA_PT_bone_groups(ArmatureButtonsPanel, Panel): sub.prop(group.colors, "active", text="") row = layout.row() - row.active = (ob.proxy is None) sub = row.row(align=True) sub.operator("pose.group_assign", text="Assign") -- cgit v1.2.3