From ad2a8400e9a263acf924311ce1fb050b0e1eb415 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Tue, 11 Feb 2020 12:35:10 +1100 Subject: Fix T56108: Crash editing corrupted vertex groups While the file in this report had corrupted values, this is avoidable without adding any extra overhead. Use unsigned vertex group indices since we don't need negative values, this is an alternative to checking they aren't negative in many places. Vertex group values over INT_MAX is still considered invalid, so any accidental unsigned wrapping won't be silently ignored. --- source/blender/blenkernel/BKE_deform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/blender/blenkernel/BKE_deform.h') diff --git a/source/blender/blenkernel/BKE_deform.h b/source/blender/blenkernel/BKE_deform.h index ca06716599c..2911002b9e9 100644 --- a/source/blender/blenkernel/BKE_deform.h +++ b/source/blender/blenkernel/BKE_deform.h @@ -106,7 +106,7 @@ void defvert_normalize_subset(struct MDeformVert *dvert, void defvert_normalize_lock_single(struct MDeformVert *dvert, const bool *vgroup_subset, const int vgroup_tot, - const int def_nr_lock); + const uint def_nr_lock); void defvert_normalize_lock_map(struct MDeformVert *dvert, const bool *vgroup_subset, const int vgroup_tot, -- cgit v1.2.3