From c6e3a20ab60ba8fb56886913a5c7a4269d45b4c3 Mon Sep 17 00:00:00 2001 From: Bastien Montagne Date: Wed, 13 Feb 2019 14:58:38 +0100 Subject: Fix T61506: Wrong user counting with ID properties in pynodes. Nuke away old nodeCopyNode(), much better to use new BKE_node_copy_ex(), which behaves as expected for the various optional flags that can be passed. This also removes the need to handle ID refcounting in calling code (ugly!) and allows us to remove an even uglier name from our codebase! :D Note that this fixes three related issues actually, that bug was also affecting copy/paste of nodes, and 'Separate with copy' operator (the latter being actually fully wrong, since it was not refcounting anything, not even node->id pointer...). --- source/blender/blenkernel/BKE_node.h | 1 - 1 file changed, 1 deletion(-) (limited to 'source/blender/blenkernel/BKE_node.h') diff --git a/source/blender/blenkernel/BKE_node.h b/source/blender/blenkernel/BKE_node.h index 7061b68e752..5d152569440 100644 --- a/source/blender/blenkernel/BKE_node.h +++ b/source/blender/blenkernel/BKE_node.h @@ -450,7 +450,6 @@ void nodeFreeNode(struct bNodeTree *ntree, struct bNode *node); void nodeDeleteNode(struct Main *bmain, struct bNodeTree *ntree, struct bNode *node); struct bNode *BKE_node_copy_ex(struct bNodeTree *ntree, struct bNode *node_src, const int flag); -struct bNode *nodeCopyNode(struct bNodeTree *ntree, struct bNode *node); struct bNodeLink *nodeAddLink(struct bNodeTree *ntree, struct bNode *fromnode, struct bNodeSocket *fromsock, struct bNode *tonode, struct bNodeSocket *tosock); void nodeRemLink(struct bNodeTree *ntree, struct bNodeLink *link); -- cgit v1.2.3