From fec9615ea06c94b5224c14479c31c55c567fb7ee Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Tue, 21 May 2019 17:29:58 +0200 Subject: Masks: Properly port to Copy-on-Write concept Masks were not really covered by Copy-on-Write due to mistake in the dependency graph. After correcting that mistake a lot of tools became broken, so majority of the patch is related on making it so access to evaluated/tessellated masks is done. When accessing evaluated mask state make sure access to an evaluated dependency graph is done. This solves possible access to NULL data on redo. Fixes T64899: Re-doing new point addition causes crash Reviewers: brecht Reviewed By: brecht Maniphest Tasks: T64899 Differential Revision: https://developer.blender.org/D4918 --- source/blender/blenkernel/intern/mask.c | 7 ------- 1 file changed, 7 deletions(-) (limited to 'source/blender/blenkernel/intern/mask.c') diff --git a/source/blender/blenkernel/intern/mask.c b/source/blender/blenkernel/intern/mask.c index 43fc8152c7b..bb93d068bef 100644 --- a/source/blender/blenkernel/intern/mask.c +++ b/source/blender/blenkernel/intern/mask.c @@ -1469,13 +1469,6 @@ void BKE_mask_evaluate(Mask *mask, const float ctime, const bool do_newframe) } } -/* the purpose of this function is to ensure spline->points_deform is never out of date. - * for now re-evaluate all. eventually this might work differently */ -void BKE_mask_update_display(Mask *mask, float ctime) -{ - BKE_mask_evaluate(mask, ctime, false); -} - void BKE_mask_evaluate_all_masks(Main *bmain, float ctime, const bool do_newframe) { Mask *mask; -- cgit v1.2.3