From 6b4cecc4662f6f7e5c99f1bf2b1706771c37a00b Mon Sep 17 00:00:00 2001 From: Lukas Toenne Date: Sat, 23 Apr 2011 07:21:10 +0000 Subject: Fix for group output memory leak, bug #27104. This happens when an internal node in a group has multiple output buffers, but only some of them are used. Then all the buffers would be created, but the unlinked outputs were not correctly tagged for freeing after group execution. --- source/blender/blenkernel/intern/node.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) (limited to 'source/blender/blenkernel/intern') diff --git a/source/blender/blenkernel/intern/node.c b/source/blender/blenkernel/intern/node.c index 18268d72609..fed982a8f1d 100644 --- a/source/blender/blenkernel/intern/node.c +++ b/source/blender/blenkernel/intern/node.c @@ -1997,11 +1997,23 @@ static void node_group_execute(bNodeStack *stack, void *data, bNode *gnode, bNod if (ntree->type==NTREE_COMPOSIT) { bNodeSocket *sock; bNodeStack *ns; + + /* clear hasoutput on all local stack data, + * only the group output will be used from now on + */ + for (node=ntree->nodes.first; node; node=node->next) { + for (sock=node->outputs.first; sock; sock=sock->next) { + if (sock->stack_type==SOCK_STACK_LOCAL) { + ns= get_socket_stack(stack, sock, in); + ns->hasoutput = 0; + } + } + } + /* use the hasoutput flag to tag external sockets */ for (sock=ntree->outputs.first; sock; sock=sock->next) { - /* use the hasoutput flag to tag external sockets */ if (sock->stack_type==SOCK_STACK_LOCAL) { ns= get_socket_stack(stack, sock, in); - ns->hasoutput = 0; + ns->hasoutput = 1; } } /* now free all stacks that are not used from outside */ @@ -2009,11 +2021,9 @@ static void node_group_execute(bNodeStack *stack, void *data, bNode *gnode, bNod for (sock=node->outputs.first; sock; sock=sock->next) { if (sock->stack_type==SOCK_STACK_LOCAL ) { ns= get_socket_stack(stack, sock, in); - if (ns->hasoutput!=0 && ns->data) { + if (ns->hasoutput==0 && ns->data) { free_compbuf(ns->data); ns->data = NULL; - /* reset the flag */ - ns->hasoutput = 1; } } } -- cgit v1.2.3