From f0cf15b5c68a1332707fe88985d21e238736ab40 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Wed, 1 Mar 2017 12:45:51 +0100 Subject: Task scheduler: Remove counter of done tasks This was only used for progress report, and it's wrong because: - Pool might in theory be re-used by different tasks - We should not make any decision based on scheduling stats Proper way is to take care of progress by the task itself. --- source/blender/blenlib/intern/task.c | 8 -------- 1 file changed, 8 deletions(-) (limited to 'source/blender/blenlib/intern/task.c') diff --git a/source/blender/blenlib/intern/task.c b/source/blender/blenlib/intern/task.c index fc2d9674c2f..c4761e9f7ef 100644 --- a/source/blender/blenlib/intern/task.c +++ b/source/blender/blenlib/intern/task.c @@ -106,7 +106,6 @@ struct TaskPool { TaskScheduler *scheduler; volatile size_t num; - volatile size_t done; size_t num_threads; size_t currently_running_tasks; ThreadMutex num_mutex; @@ -238,7 +237,6 @@ static void task_pool_num_decrease(TaskPool *pool, size_t done) pool->num -= done; atomic_sub_and_fetch_z(&pool->currently_running_tasks, done); - pool->done += done; if (pool->num == 0) BLI_condition_notify_all(&pool->num_cond); @@ -504,7 +502,6 @@ static TaskPool *task_pool_create_ex(TaskScheduler *scheduler, void *userdata, c pool->scheduler = scheduler; pool->num = 0; - pool->done = 0; pool->num_threads = 0; pool->currently_running_tasks = 0; pool->do_cancel = false; @@ -743,11 +740,6 @@ ThreadMutex *BLI_task_pool_user_mutex(TaskPool *pool) return &pool->user_mutex; } -size_t BLI_task_pool_tasks_done(TaskPool *pool) -{ - return pool->done; -} - /* Parallel range routines */ /** -- cgit v1.2.3