From 254daf8f8c276a4e5292e5a12fcfa88296131878 Mon Sep 17 00:00:00 2001 From: Julian Eisel Date: Tue, 24 Oct 2017 00:32:07 +0200 Subject: Fix T53141: Assert when using transformation in new 3D View editor Was actually possible to invoke this assert failure in two ways: * Transforming in newly created 3D View (like described in the report). * Transforming in newly appended workspace from default workspaces.blend. Issue was that default workspaces.blend was saved in 2.8.1, but in a branch state that didn't include the transform-orientation changes. So versioning code wouldn't run when needed. Note that files saved with this bug will still cause the assert to fail. Can be ignored then. This is not related to manipulators (as suggested in the report). --- source/blender/blenloader/intern/versioning_280.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source/blender/blenloader') diff --git a/source/blender/blenloader/intern/versioning_280.c b/source/blender/blenloader/intern/versioning_280.c index f052ea7b8e4..da1562d3a64 100644 --- a/source/blender/blenloader/intern/versioning_280.c +++ b/source/blender/blenloader/intern/versioning_280.c @@ -418,7 +418,9 @@ void blo_do_versions_280(FileData *fd, Library *UNUSED(lib), Main *main) } } } + } + { if (!DNA_struct_elem_find(fd->filesdna, "View3D", "short", "custom_orientation_index")) { for (bScreen *screen = main->screen.first; screen; screen = screen->id.next) { for (ScrArea *area = screen->areabase.first; area; area = area->next) { @@ -437,9 +439,7 @@ void blo_do_versions_280(FileData *fd, Library *UNUSED(lib), Main *main) } } } - } - { if (!DNA_struct_elem_find(fd->filesdna, "Lamp", "float", "cascade_max_dist")) { for (Lamp *la = main->lamp.first; la; la = la->id.next) { la->cascade_max_dist = 1000.0f; -- cgit v1.2.3