From 533e267e95cf1115eebde95a67dc3b05d48e6ffd Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Fri, 28 Jun 2019 14:59:50 +0200 Subject: Remove Sticky option from the Floor constraint This option from the very beginning of its existence needed more work to make it work correct and this was never done. This option was working fine during continuous playback, when there are no skipped frames, but it was failing when AV-sync of framedrop was enabled. It was never working correct when jumping between frames, including rendering on a farm which usually does frame-range based rendering. With copy-on-write things became even more tricky, since the "stuck" flag was never preserved between re-evaluations. Fixes T65683: Sticky Option in Floor Constraint for Bones Not Working --- .../blender/blenloader/intern/versioning_legacy.c | 21 --------------------- 1 file changed, 21 deletions(-) (limited to 'source/blender/blenloader') diff --git a/source/blender/blenloader/intern/versioning_legacy.c b/source/blender/blenloader/intern/versioning_legacy.c index df26ca37826..69802b35ff9 100644 --- a/source/blender/blenloader/intern/versioning_legacy.c +++ b/source/blender/blenloader/intern/versioning_legacy.c @@ -1738,17 +1738,6 @@ void blo_do_versions_pre250(FileData *fd, Library *lib, Main *bmain) bConstraint *curcon; for (curcon = list->first; curcon; curcon = curcon->next) { switch (curcon->type) { - case CONSTRAINT_TYPE_MINMAX: { - bMinMaxConstraint *data = curcon->data; - if (data->sticky == 1) { - data->flag |= MINMAX_STICKY; - } - else { - data->flag &= ~MINMAX_STICKY; - } - - break; - } case CONSTRAINT_TYPE_ROTLIKE: { bRotateLikeConstraint *data = curcon->data; @@ -1770,16 +1759,6 @@ void blo_do_versions_pre250(FileData *fd, Library *lib, Main *bmain) for (pchan = ob->pose->chanbase.first; pchan; pchan = pchan->next) { for (curcon = pchan->constraints.first; curcon; curcon = curcon->next) { switch (curcon->type) { - case CONSTRAINT_TYPE_MINMAX: { - bMinMaxConstraint *data = curcon->data; - if (data->sticky == 1) { - data->flag |= MINMAX_STICKY; - } - else { - data->flag &= ~MINMAX_STICKY; - } - break; - } case CONSTRAINT_TYPE_KINEMATIC: { bKinematicConstraint *data = curcon->data; if (!(data->flag & CONSTRAINT_IK_POS)) { -- cgit v1.2.3