From 59bae6d149445ec3b24576d7d134f35415d2eba6 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Fri, 14 Feb 2020 19:39:43 +1100 Subject: BMesh: stop BM_mesh_elem_index_validate from setting indices This prevented indices from being set to temporary values, which is needed in some situations. --- source/blender/bmesh/intern/bmesh_mesh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'source/blender/bmesh') diff --git a/source/blender/bmesh/intern/bmesh_mesh.c b/source/blender/bmesh/intern/bmesh_mesh.c index 15de281ded4..334cb7c3db4 100644 --- a/source/blender/bmesh/intern/bmesh_mesh.c +++ b/source/blender/bmesh/intern/bmesh_mesh.c @@ -1838,7 +1838,8 @@ void BM_mesh_elem_index_ensure(BMesh *bm, const char htype) * To avoid correcting them afterwards, set 'bm->elem_index_dirty' however its possible * this flag is set incorrectly which could crash blender. * - * These functions ensure its correct and are called more often in debug mode. + * Code that calls this functions may depend on dirty indices on being set. + * Keep this function read-only. */ void BM_mesh_elem_index_validate( @@ -1867,10 +1868,9 @@ void BM_mesh_elem_index_validate( err_val = BM_elem_index_get(ele); err_idx = index; is_error = true; + break; } } - - BM_elem_index_set(ele, index); /* set_ok */ index++; } -- cgit v1.2.3