From fd05f01be60128e70b7e53d566627c9e84b6a98d Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Sun, 8 Sep 2019 03:31:49 +1000 Subject: Partially revert "Cleanup: use post increment/decrement" This partially reverts commit 0b2d1badecc48b5cbff5ec088b29c6e9acc5e1d0 Post increment can deep-copy for C++ iterators, while in my own checks GCC was able to optimize this to get the same output, better follow C++ best practice and use pre-increment for iterators. --- source/blender/collada/AnimationExporter.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'source/blender/collada/AnimationExporter.cpp') diff --git a/source/blender/collada/AnimationExporter.cpp b/source/blender/collada/AnimationExporter.cpp index c2ba397131c..9d0d075cade 100644 --- a/source/blender/collada/AnimationExporter.cpp +++ b/source/blender/collada/AnimationExporter.cpp @@ -100,7 +100,7 @@ bool AnimationExporter::exportAnimations() openLibrary(); BCObjectSet::iterator it; - for (it = animated_subset.begin(); it != animated_subset.end(); it++) { + for (it = animated_subset.begin(); it != animated_subset.end(); ++it) { Object *ob = *it; exportAnimation(ob, animation_sampler); } @@ -183,7 +183,7 @@ void AnimationExporter::export_curve_animation_set(Object *ob, bool keep_flat_curves = this->export_settings.get_keep_flat_curves(); BCAnimationCurveMap::iterator it; - for (it = curves->begin(); it != curves->end(); it++) { + for (it = curves->begin(); it != curves->end(); ++it) { BCAnimationCurve &curve = *it->second; std::string channel_type = curve.get_channel_type(); if (channel_type == "rotation_quaternion") { @@ -310,7 +310,7 @@ BCAnimationCurve *AnimationExporter::get_modified_export_curve(Object *ob, } BCValueMap::const_iterator vit; - for (vit = lens_values.begin(); vit != lens_values.end(); vit++) { + for (vit = lens_values.begin(); vit != lens_values.end(); ++vit) { int frame = vit->first; float lens_value = vit->second; -- cgit v1.2.3