From ca2484e09005207e7bad90f484de6cbba1013833 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Tue, 10 Apr 2018 15:07:39 +0200 Subject: Depsgraph: Remove function bindings with collections Use single function to evaluate all the collections for the given view layer. This way we avoid need to get scene ID sub-data. Similar to pchan index, this allows us to avoid build-time scene expansion, which also simplifies update of the scene datablock. Well, sort of. There is still work to be done to get rid of build-time scene datablock expansion, which includes: - Need to pass view layer by index. Annoying part would be to get actual view layer for that index. In practice doing list lookup might not be such a bad idea, since such lookup will not happen very often, and it is unlikely to have more than handful of view layer anyway. Other idea could be to use view layer from evaluation context. Or maybe from depsgraph, which is supposed to be in the context. Can have some assert statements to make sure everything is good. - Need to get id of base binding for flags flush. We can replace that with index-based lookup from an array created by view layer evaluation. Reviewers: dfelinto Differential Revision: https://developer.blender.org/D3141 --- source/blender/depsgraph/intern/depsgraph_types.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'source/blender/depsgraph/intern/depsgraph_types.h') diff --git a/source/blender/depsgraph/intern/depsgraph_types.h b/source/blender/depsgraph/intern/depsgraph_types.h index 3aa204490eb..d6c410347f6 100644 --- a/source/blender/depsgraph/intern/depsgraph_types.h +++ b/source/blender/depsgraph/intern/depsgraph_types.h @@ -245,9 +245,7 @@ typedef enum eDepsOperation_Code { DEG_OPCODE_POINT_CACHE_RESET, /* Collections. ------------------------------------- */ - DEG_OPCODE_VIEW_LAYER_INIT, DEG_OPCODE_VIEW_LAYER_EVAL, - DEG_OPCODE_VIEW_LAYER_DONE, /* Copy on Write. ------------------------------------ */ DEG_OPCODE_COPY_ON_WRITE, -- cgit v1.2.3