From fd05f01be60128e70b7e53d566627c9e84b6a98d Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Sun, 8 Sep 2019 03:31:49 +1000 Subject: Partially revert "Cleanup: use post increment/decrement" This partially reverts commit 0b2d1badecc48b5cbff5ec088b29c6e9acc5e1d0 Post increment can deep-copy for C++ iterators, while in my own checks GCC was able to optimize this to get the same output, better follow C++ best practice and use pre-increment for iterators. --- source/blender/depsgraph/intern/builder/deg_builder_transitive.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source/blender/depsgraph') diff --git a/source/blender/depsgraph/intern/builder/deg_builder_transitive.cc b/source/blender/depsgraph/intern/builder/deg_builder_transitive.cc index 34d2afcfa66..13cf8e63832 100644 --- a/source/blender/depsgraph/intern/builder/deg_builder_transitive.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_transitive.cc @@ -92,7 +92,7 @@ void deg_graph_transitive_reduction(Depsgraph *graph) * set/cleared. */ /* TODO: there will be other types in future, so iterators above * need modifying. */ - it_rel++; + ++it_rel; } else if (rel->from->custom_flags & OP_REACHABLE) { rel->unlink(); @@ -100,7 +100,7 @@ void deg_graph_transitive_reduction(Depsgraph *graph) num_removed_relations++; } else { - it_rel++; + ++it_rel; } } } -- cgit v1.2.3