From a6dd22d4311ce0265bd7678b68bff71c59404771 Mon Sep 17 00:00:00 2001 From: Philipp Oeser Date: Fri, 20 Mar 2020 10:30:35 +0100 Subject: Fix T74957: Matcap flip not updating Caused by rBc476c36e4008. This hooks into the existing FIXME (workaround for a missing update tagging from operators), needs to also check the shading.flag (to detect changes in V3D_SHADING_MATCAP_FLIP_X). Differential Revision: https://developer.blender.org/D7192 --- source/blender/draw/engines/workbench/workbench_data.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'source/blender/draw/engines/workbench/workbench_data.c') diff --git a/source/blender/draw/engines/workbench/workbench_data.c b/source/blender/draw/engines/workbench/workbench_data.c index f000028562f..ceb57327fb0 100644 --- a/source/blender/draw/engines/workbench/workbench_data.c +++ b/source/blender/draw/engines/workbench/workbench_data.c @@ -203,7 +203,8 @@ void workbench_private_data_init(WORKBENCH_PrivateData *wpd) /* FIXME: This reproduce old behavior when workbench was separated in 2 engines. * But this is a workaround for a missing update tagging from operators. */ if (scene->display.shading.type != wpd->shading.type || - (v3d && (XRAY_ENABLED(v3d) != XRAY_ENABLED(&scene->display)))) { + (v3d && (XRAY_ENABLED(v3d) != XRAY_ENABLED(&scene->display))) || + (scene->display.shading.flag != wpd->shading.flag)) { wpd->view_updated = true; } @@ -229,7 +230,8 @@ void workbench_private_data_init(WORKBENCH_PrivateData *wpd) else { /* FIXME: This reproduce old behavior when workbench was separated in 2 engines. * But this is a workaround for a missing update tagging from operators. */ - if (v3d->shading.type != wpd->shading.type || XRAY_ENABLED(v3d) != XRAY_ENABLED(wpd)) { + if (v3d->shading.type != wpd->shading.type || XRAY_ENABLED(v3d) != XRAY_ENABLED(wpd) || + v3d->shading.flag != wpd->shading.flag) { wpd->view_updated = true; } -- cgit v1.2.3