From 9ca67c47a152a24e0740dbedc09a4bfeec2b6d73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Foucault?= Date: Sat, 20 Mar 2021 21:58:04 +0100 Subject: Fix T86660 EEVEE: Undefined behaviour in specular_occlusion Define visibility error to be 1 by default to avoid undefined behaviour. --- source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl | 3 +++ 1 file changed, 3 insertions(+) (limited to 'source/blender/draw') diff --git a/source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl b/source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl index dc5c048422b..69b9ecaf77d 100644 --- a/source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl +++ b/source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl @@ -198,6 +198,9 @@ void occlusion_eval(OcclusionData data, out float visibility_error, out vec3 bent_normal) { + /* No error by default. */ + visibility_error = 1.0; + if ((int(aoSettings) & USE_AO) == 0) { visibility = data.custom_occlusion; bent_normal = N; -- cgit v1.2.3