From 498397f7bd8158aec654d12ddf063868829b5903 Mon Sep 17 00:00:00 2001 From: Philipp Oeser Date: Thu, 27 Feb 2020 15:47:32 +0100 Subject: Fix (unreported) Separate bones creates empty armature Fix for fix (rB8bf7ca9fe31c). The fix was not actually working [neither for multi-armature-editing as intended nor for single armatures] and it broke single-armature bone separation completely. More or less indentation issue, move relevant code out of bone loop, do after all bones have been checked, guess this was intended anyways. Differential Revision: https://developer.blender.org/D6949 --- source/blender/editors/armature/armature_relations.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'source/blender/editors/armature') diff --git a/source/blender/editors/armature/armature_relations.c b/source/blender/editors/armature/armature_relations.c index c2c7d7e5ee7..ae0501d14ef 100644 --- a/source/blender/editors/armature/armature_relations.c +++ b/source/blender/editors/armature/armature_relations.c @@ -639,14 +639,14 @@ static int separate_armature_exec(bContext *C, wmOperator *op) has_selected_any = true; } } - if (has_selected_bone == false) { - if (has_selected_any) { - /* Without this, we may leave head/tail selected - * which isn't expected after separating. */ - ED_armature_edit_deselect_all(ob_old); - } - continue; + } + if (has_selected_bone == false) { + if (has_selected_any) { + /* Without this, we may leave head/tail selected + * which isn't expected after separating. */ + ED_armature_edit_deselect_all(ob_old); } + continue; } } -- cgit v1.2.3