From 95d8cfc25df30adbb18437b8de0bc840797574ee Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Thu, 25 Nov 2010 19:49:07 +0000 Subject: bugfix [#24907] bone roll z up broken and python script showing correct method to roll bones from Josh Wedlake (joshwedlake), who provided a reference script used to apply changes in ED_rollBoneToVector(). - Obvious bug fixed where Z-Up didnt work right. - More align axis options to Recalculate Roll operator: X/Y/Z/View Axis & Negate. - Axis Only option, ignore the axis direction, use shortest rotation to align bones. ED_rollBoneToVector() changes: - would give bad roll when the axis wasn't normalized or perpendicular to the bone. some callers accounted for this but not all. - option to align to the axis but not the direction. --- source/blender/editors/include/ED_armature.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/blender/editors/include/ED_armature.h') diff --git a/source/blender/editors/include/ED_armature.h b/source/blender/editors/include/ED_armature.h index 16091e43caf..0db8ffd733e 100644 --- a/source/blender/editors/include/ED_armature.h +++ b/source/blender/editors/include/ED_armature.h @@ -115,7 +115,7 @@ int ED_do_pose_selectbuffer(struct Scene *scene, struct Base *base, unsigned int int mouse_armature(struct bContext *C, short mval[2], int extend); int join_armature_exec(struct bContext *C, struct wmOperator *op); struct Bone *get_indexed_bone (struct Object *ob, int index); -float ED_rollBoneToVector(EditBone *bone, float new_up_axis[3]); +float ED_rollBoneToVector(EditBone *bone, const float new_up_axis[3], const short axis_only); EditBone *ED_armature_bone_get_mirrored(struct ListBase *edbo, EditBone *ebo); // XXX this is needed for populating the context iterators void ED_armature_sync_selection(struct ListBase *edbo); void ED_armature_validate_active(struct bArmature *arm); -- cgit v1.2.3