From a750acab78cf38ca8f010c4ac81ec948faa79dd5 Mon Sep 17 00:00:00 2001 From: Julian Eisel Date: Mon, 2 Nov 2020 21:47:08 +0100 Subject: Fix possible use-after-free when closing Blender with File Browser open I think there wasn't actually any issue currently, but only by luck. We still passed around and NULL-checked a pointer to freed memory (the file operator, `SpaceFile.op`) which is easy to break and should be avoided. Noticed while testing D8598. --- source/blender/editors/include/ED_fileselect.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'source/blender/editors/include') diff --git a/source/blender/editors/include/ED_fileselect.h b/source/blender/editors/include/ED_fileselect.h index 341f97943a5..84808416074 100644 --- a/source/blender/editors/include/ED_fileselect.h +++ b/source/blender/editors/include/ED_fileselect.h @@ -35,6 +35,7 @@ struct SpaceFile; struct bContext; struct bScreen; struct uiBlock; +struct wmOperator; struct wmWindow; struct wmWindowManager; @@ -145,6 +146,9 @@ void ED_fileselect_window_params_get(const struct wmWindow *win, int win_size[2], bool *is_maximized); +struct ScrArea *ED_fileselect_handler_area_find(const struct wmWindow *win, + const struct wmOperator *file_operator); + int ED_path_extension_type(const char *path); int ED_file_extension_icon(const char *path); -- cgit v1.2.3