From d61d68a310bd8d8f4bbfe325cf54dda8c19e7fbe Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Tue, 17 Dec 2019 12:11:28 +1100 Subject: Cleanup: remove redundant string initialization Fixed sized strings are always initialized & this is not done elsewhere before calling BLI_path_join. Remove since it's not needed and makes it read as if the function might not initialize the output argument. --- source/blender/editors/physics/physics_fluid.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'source/blender/editors/physics') diff --git a/source/blender/editors/physics/physics_fluid.c b/source/blender/editors/physics/physics_fluid.c index 6c1c7afbebd..e25cedc51a4 100644 --- a/source/blender/editors/physics/physics_fluid.c +++ b/source/blender/editors/physics/physics_fluid.c @@ -364,7 +364,6 @@ static void fluid_bake_startjob(void *customdata, short *stop, short *do_update, FluidDomainSettings *mds = job->mmd->domain; char temp_dir[FILE_MAX]; - temp_dir[0] = '\0'; job->stop = stop; job->do_update = do_update; @@ -377,7 +376,6 @@ static void fluid_bake_startjob(void *customdata, short *stop, short *do_update, BKE_spacedata_draw_locks(true); if (fluid_is_bake_noise(job) || fluid_is_bake_all(job)) { - temp_dir[0] = '\0'; BLI_path_join(temp_dir, sizeof(temp_dir), mds->cache_directory, FLUID_DOMAIN_DIR_NOISE, NULL); BLI_dir_create_recursive(temp_dir); /* Create 'noise' subdir if it does not exist already */ mds->cache_flag &= ~(FLUID_DOMAIN_BAKED_NOISE | FLUID_DOMAIN_OUTDATED_NOISE); @@ -385,7 +383,6 @@ static void fluid_bake_startjob(void *customdata, short *stop, short *do_update, job->pause_frame = &mds->cache_frame_pause_noise; } if (fluid_is_bake_mesh(job) || fluid_is_bake_all(job)) { - temp_dir[0] = '\0'; BLI_path_join(temp_dir, sizeof(temp_dir), mds->cache_directory, FLUID_DOMAIN_DIR_MESH, NULL); BLI_dir_create_recursive(temp_dir); /* Create 'mesh' subdir if it does not exist already */ mds->cache_flag &= ~(FLUID_DOMAIN_BAKED_MESH | FLUID_DOMAIN_OUTDATED_MESH); @@ -393,7 +390,6 @@ static void fluid_bake_startjob(void *customdata, short *stop, short *do_update, job->pause_frame = &mds->cache_frame_pause_mesh; } if (fluid_is_bake_particle(job) || fluid_is_bake_all(job)) { - temp_dir[0] = '\0'; BLI_path_join( temp_dir, sizeof(temp_dir), mds->cache_directory, FLUID_DOMAIN_DIR_PARTICLES, NULL); BLI_dir_create_recursive( @@ -403,7 +399,6 @@ static void fluid_bake_startjob(void *customdata, short *stop, short *do_update, job->pause_frame = &mds->cache_frame_pause_particles; } if (fluid_is_bake_guiding(job) || fluid_is_bake_all(job)) { - temp_dir[0] = '\0'; BLI_path_join( temp_dir, sizeof(temp_dir), mds->cache_directory, FLUID_DOMAIN_DIR_GUIDING, NULL); BLI_dir_create_recursive(temp_dir); /* Create 'guiding' subdir if it does not exist already */ @@ -412,10 +407,9 @@ static void fluid_bake_startjob(void *customdata, short *stop, short *do_update, job->pause_frame = &mds->cache_frame_pause_guiding; } if (fluid_is_bake_data(job) || fluid_is_bake_all(job)) { - temp_dir[0] = '\0'; BLI_path_join(temp_dir, sizeof(temp_dir), mds->cache_directory, FLUID_DOMAIN_DIR_CONFIG, NULL); BLI_dir_create_recursive(temp_dir); /* Create 'config' subdir if it does not exist already */ - temp_dir[0] = '\0'; + BLI_path_join(temp_dir, sizeof(temp_dir), mds->cache_directory, FLUID_DOMAIN_DIR_DATA, NULL); BLI_dir_create_recursive(temp_dir); /* Create 'data' subdir if it does not exist already */ mds->cache_flag &= ~(FLUID_DOMAIN_BAKED_DATA | FLUID_DOMAIN_OUTDATED_DATA); -- cgit v1.2.3