From 2b77b1ce465ab09052567a58d1b9f6a014a563cd Mon Sep 17 00:00:00 2001 From: Mike Erwin Date: Thu, 21 Jul 2016 21:31:37 -0400 Subject: remove double-checked conditions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Checking a condition right after we’ve checked it (and it hasn’t changed). Most of these are trivial to understand. split_quads in convertblender.c: It seems quads should be processed and triangles should be marked as not needing split. So I removed the outer vlr->v4 check. Found with PVS-Studio T48917 --- source/blender/editors/sculpt_paint/paint_vertex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'source/blender/editors/sculpt_paint') diff --git a/source/blender/editors/sculpt_paint/paint_vertex.c b/source/blender/editors/sculpt_paint/paint_vertex.c index 7b296473f31..991025a4d5d 100644 --- a/source/blender/editors/sculpt_paint/paint_vertex.c +++ b/source/blender/editors/sculpt_paint/paint_vertex.c @@ -257,9 +257,7 @@ static bool make_vertexcol(Object *ob) /* single ob */ /* copies from shadedisplist to mcol */ if (!me->mloopcol && me->totloop) { - if (!me->mloopcol) { - CustomData_add_layer(&me->ldata, CD_MLOOPCOL, CD_DEFAULT, NULL, me->totloop); - } + CustomData_add_layer(&me->ldata, CD_MLOOPCOL, CD_DEFAULT, NULL, me->totloop); BKE_mesh_update_customdata_pointers(me, true); } -- cgit v1.2.3