From ce5fa2decad115f023e2f5591255078768b4fa5e Mon Sep 17 00:00:00 2001 From: Joshua Leung Date: Mon, 28 May 2018 16:54:34 +0200 Subject: Fix: Action/Graph editor UI's didn't update when channel properties were changed More MessageBus-related silliness to resolve issue with toggling visibility/mute/locking status of F-Curves/Groups/etc., as well as other things like modifying active keyframe's values, or changing properties of F-Modifiers. I've now ended up just whitelisting in the region subscribers all the animation-related structs in RNA. But still, that may not be enough to deal with potential issues later with the property sliders (shown per channel, optionally), which can come from anywhere. (Spring bug) --- source/blender/editors/space_graph/space_graph.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) (limited to 'source/blender/editors/space_graph/space_graph.c') diff --git a/source/blender/editors/space_graph/space_graph.c b/source/blender/editors/space_graph/space_graph.c index 3732b78a026..6ecb454096d 100644 --- a/source/blender/editors/space_graph/space_graph.c +++ b/source/blender/editors/space_graph/space_graph.c @@ -527,12 +527,29 @@ static void graph_region_message_subscribe( } /* All dopesheet filter settings, etc. affect the drawing of this editor, - * so just whitelist the entire struct for updates + * also same applies for all animation-related datatypes that may appear here, + * so just whitelist the entire structs for updates */ { wmMsgParams_RNA msg_key_params = {{{0}}}; StructRNA *type_array[] = { - &RNA_DopeSheet, + &RNA_DopeSheet, /* dopesheet filters */ + + &RNA_ActionGroup, /* channel groups */ + &RNA_FCurve, /* F-Curve */ + &RNA_Keyframe, + &RNA_FCurveSample, + + &RNA_FModifier, /* F-Modifiers (XXX: Why can't we just do all subclasses too?) */ + &RNA_FModifierCycles, + &RNA_FModifierEnvelope, + &RNA_FModifierEnvelopeControlPoint, + &RNA_FModifierFunctionGenerator, + &RNA_FModifierGenerator, + &RNA_FModifierLimits, + &RNA_FModifierNoise, + &RNA_FModifierPython, + &RNA_FModifierStepped, }; for (int i = 0; i < ARRAY_SIZE(type_array); i++) { -- cgit v1.2.3