From 7a304c2d1173a2c20ba69dc61b56dadbf35fd90f Mon Sep 17 00:00:00 2001 From: Joshua Leung Date: Mon, 1 Jul 2013 14:14:21 +0000 Subject: Bugfix [#35744] FCurve select changes on Graph Editor Resize Selection state of F-Curves is lost when resizing the Graph Editor. The problem was that SIPO_TEMP_NEEDCHANSYNC was getting set in the graph_init() callback, which gets called everytime the view resizes, and not just the very first time this happens. However, setting this flag forces the selection state to the updated/pulled from the scene data. In the past, it was necessary to set this flag so that we could force F-Curve colors to get initialised correctly. However, things probably changed at some point, so this behaviour is no longer needed. At worst now, opening a new graph editor may not show F-Curve selection correctly synced with the viewport, though that's easily worked around by reselecting whatever it is in the 3d view. --- source/blender/editors/space_graph/space_graph.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'source/blender/editors/space_graph') diff --git a/source/blender/editors/space_graph/space_graph.c b/source/blender/editors/space_graph/space_graph.c index 6e38f236d01..765c61b5bed 100644 --- a/source/blender/editors/space_graph/space_graph.c +++ b/source/blender/editors/space_graph/space_graph.c @@ -189,7 +189,10 @@ static void graph_init(struct wmWindowManager *UNUSED(wm), ScrArea *sa) } /* force immediate init of any invalid F-Curve colors */ - sipo->flag |= SIPO_TEMP_NEEDCHANSYNC; + /* XXX: but, don't do SIPO_TEMP_NEEDCHANSYNC (i.e. channel select state sync) + * as this is run on each region resize; setting this here will cause selection + * state to be lost on area/region resizing. [#35744] + */ ED_area_tag_refresh(sa); } -- cgit v1.2.3